[jira] Updated: (SOLR-1024) Calling abort on DataImportHandler import commits data

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-1024:
----------------------------------------

    Attachment: SOLR-1024.patch

In the current code, DocBuilder#abort is called in two place:
# When the user calls command=abort
# When using 'start' and 'rows' parameter to simulate aborting but committing anyway

Patch to fix the problem

Changes
# DocBuilder#abort is called only if command=abort is specified.
# DocBuilder#buildDocument is made aware of start and rows and it stops producing documents once it reaches the limit
# SolrWriter is no longer aware of start and rows and it does not call abort anymore.

I'll commit this shortly.

> Calling abort on DataImportHandler import commits data
> ------------------------------------------------------
>
>                 Key: SOLR-1024
>                 URL: https://issues.apache.org/jira/browse/SOLR-1024
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-1024.patch
>
>
> If abort is called on an ongoing import, the import is cancelled but the data is committed. It should be rolledback.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.