[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #308: RATIS-1178. Use RaftClient to submit request

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #308:
URL: https://github.com/apache/incubator-ratis/pull/308#discussion_r533160847



##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/DataStreamTestUtils.java
##########
@@ -343,10 +343,8 @@ static void assertHeader(RaftServer server, RaftClientRequest header, int dataSi
 
   static void assertRaftClientMessage(RaftClientMessage expected, RaftPeerId expectedServerId, RaftClientMessage computed) {
     Assert.assertNotNull(computed);
-    Assert.assertEquals(expected.getClientId(), computed.getClientId());

Review comment:
       Similar to expectedServerId, let's pass the clientId in Primary as the expectedClientId (a new parameter).

##########
File path: ratis-client/src/main/java/org/apache/ratis/client/RaftClient.java
##########
@@ -53,8 +52,8 @@
   /** Get the {@link GroupManagementApi} for the given server. */
   GroupManagementApi getGroupManagementApi(RaftPeerId server);
 
-  /** Get the {@link AsyncApi}. */
-  AsyncApi async();
+  /** Get the {@link AsyncRpcApi}. */
+  AsyncRpcApi async();

Review comment:
       We should keep returning AsyncApi in order to hide AsyncRpcApi.  We will cast it to AsyncRpcApi in our code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org