You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "stillalex (via GitHub)" <gi...@apache.org> on 2023/09/25 20:26:57 UTC
[GitHub] [solr] stillalex commented on pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI
stillalex commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1734414823
re. this pattern of parsing `user:password`
```
if (credentials != null && credentials.indexOf(":") > 0) {
String[] credentialsArray = credentials.split(":");
```
what happens if the password itself contains `:` (I don't think the username is allowed to but I may be wrong). would it be a safer bet to break the string in 2 parts on the first occurrence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org