You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:24:06 UTC
[GitHub] [incubator-shenyu] leontius commented on a change in pull request #1632: fix (admin,client): Add the thread pool name to the thread pool of shenyu-client
leontius commented on a change in pull request #1632:
URL: https://github.com/apache/incubator-shenyu/pull/1632#discussion_r654255500
##########
File path: shenyu-client/shenyu-client-sofa/src/main/java/org/apache/shenyu/client/sofa/SofaServiceBeanPostProcessor.java
##########
@@ -75,7 +76,8 @@ public SofaServiceBeanPostProcessor(final ShenyuRegisterCenterConfig config, fin
this.appName = appName;
this.host = props.getProperty("host");
this.port = props.getProperty("port");
- executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>());
+ executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(), new ThreadFactoryBuilder()
+ .setNameFormat("sofa-client-thread-pool-%d").build());
Review comment:
ok, let me change it.
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/AlibabaDubboServiceBeanListener.java
##########
@@ -78,7 +79,8 @@ public AlibabaDubboServiceBeanListener(final ShenyuRegisterCenterConfig config,
this.appName = appName;
this.host = props.getProperty("host");
this.port = props.getProperty("port");
- executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>());
+ executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(), new ThreadFactoryBuilder()
Review comment:
Maybe someone watched alibaba p3c before.
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/AlibabaDubboServiceBeanListener.java
##########
@@ -78,7 +79,8 @@ public AlibabaDubboServiceBeanListener(final ShenyuRegisterCenterConfig config,
this.appName = appName;
this.host = props.getProperty("host");
this.port = props.getProperty("port");
- executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>());
+ executorService = new ThreadPoolExecutor(1, 1, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>(), new ThreadFactoryBuilder()
Review comment:
finished. please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org