You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/31 07:25:47 UTC

[GitHub] [incubator-druid] pjain1 commented on a change in pull request #8157: Enum of ResponseContext keys

pjain1 commented on a change in pull request #8157: Enum of ResponseContext keys
URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309032749
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerTest.java
 ##########
 @@ -1301,9 +1301,7 @@ public void testTopNBySegment()
         )
     );
 
-    final ResponseContext responseContext = ResponseContext.createEmpty();
-    responseContext.putAll(specialContext);
-    Sequence<Result<TopNResultValue>> results = runWithMerge(query, responseContext);
+    Sequence<Result<TopNResultValue>> results = runWithMerge(query);
 
 Review comment:
   Is `specialContext` not required now to be a part of response context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org