[GitHub] [superset] eschutho commented on a diff in pull request #23041: chore: increment statsd as warn

["eschutho (via GitHub)" <gi...@apache.org>]

eschutho commented on code in PR #23041:
URL: https://github.com/apache/superset/pull/23041#discussion_r1107512018


##########
tests/unit_tests/utils/test_decorators.py:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+from enum import Enum
+from typing import Any
+from unittest.mock import call, Mock, patch
+
+import pytest
+
+from superset import app
+from superset.utils import decorators
+
+
+class ResponseValues(str, Enum):
+    FAIL = "fail"
+    WARN = "warn"
+    OK = "ok"
+
+
+def test_debounce() -> None:
+    mock = Mock()
+
+    @decorators.debounce()
+    def myfunc(arg1: int, arg2: int, kwarg1: str = "abc", kwarg2: int = 2) -> int:
+        mock(arg1, kwarg1)
+        return arg1 + arg2 + kwarg2
+
+    # should be called only once when arguments don't change
+    myfunc(1, 1)
+    myfunc(1, 1)
+    result = myfunc(1, 1)
+    mock.assert_called_once_with(1, "abc")
+    assert result == 4
+
+    # kwarg order shouldn't matter
+    myfunc(1, 0, kwarg2=2, kwarg1="haha")
+    result = myfunc(1, 0, kwarg1="haha", kwarg2=2)
+    mock.assert_has_calls([call(1, "abc"), call(1, "haha")])
+    assert result == 3
+
+
+def test_statsd_gauge() -> None:
+    @decorators.statsd_gauge("custom.prefix")
+    def my_func(response: ResponseValues, *args: Any, **kwargs: Any) -> str:
+        if response == ResponseValues.FAIL:
+            raise ValueError("Error")
+        if response == ResponseValues.WARN:
+            raise FileNotFoundError("Not found")
+        return "OK"
+
+    with patch.object(app.config["STATS_LOGGER"], "gauge") as mock:
+        my_func(ResponseValues.OK, 1, 2)
+        mock.assert_called_once_with("custom.prefix.ok", 1)
+
+        with pytest.raises(ValueError):
+            my_func(ResponseValues.FAIL, 1, 2)
+            mock.assert_called_once_with("custom.prefix.error", 1)
+
+        with pytest.raises(FileNotFoundError):
+            my_func(ResponseValues.WARN, 1, 2)
+            mock.assert_called_once_with("custom.prefix.warn", 1)

Review Comment:
   Thanks, this is a great suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org