You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ken Sipe <ke...@gmail.com> on 2014/07/29 16:54:47 UTC
Review Request 24057: Help Flag Cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/
-----------------------------------------------------------
Review request for mesos, Adam B and Ben Mahler.
Repository: mesos-git
Description
-------
The --help on master and slave have a number of issues which are resolved with this patch.
1. consistency - Path, Location, Where are all used to describe the path of a directory or file. These are cleaned up.
2. zk path for a file must be file:/// not file://. I get that the last / is part of the path, however without an example it can be confusing to newbies
3. --registration_backoff_factor help refers to a register_backoff_factor value which is incorrect.
4. Attribute's notation really needs an example (which is added).
Diffs
-----
src/logging/flags.hpp 08101b87e5843e8c8f3a74b87d46138a5ff2a97e
src/master/flags.hpp 32704ce19c20815315b0f6bc4efc535f01c00c30
src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a
src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25
src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb
Diff: https://reviews.apache.org/r/24057/diff/
Testing
-------
style check, compiling and manual review
Thanks,
Ken Sipe
Re: Review Request 24057: Help Flag Cleanup
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/#review49061
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 29, 2014, 10:53 p.m., Ken Sipe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24057/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 10:53 p.m.)
>
>
> Review request for mesos, Adam B and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The --help on master and slave have a number of issues which are resolved with this patch.
> 1. consistency - Path, Location, Where are all used to describe the path of a directory or file. These are cleaned up.
> 2. zk path for a file must be file:/// not file://. I get that the last / is part of the path, however without an example it can be confusing to newbies
> 3. --registration_backoff_factor help refers to a register_backoff_factor value which is incorrect.
> 4. Attribute's notation really needs an example (which is added).
>
>
> Diffs
> -----
>
> src/logging/flags.hpp 08101b87e5843e8c8f3a74b87d46138a5ff2a97e
> src/master/flags.hpp 32704ce19c20815315b0f6bc4efc535f01c00c30
> src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a
> src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25
> src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb
>
> Diff: https://reviews.apache.org/r/24057/diff/
>
>
> Testing
> -------
>
> style check, compiling and manual review
>
>
> Thanks,
>
> Ken Sipe
>
>
Re: Review Request 24057: Help Flag Cleanup
Posted by Ken Sipe <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/
-----------------------------------------------------------
(Updated July 29, 2014, 10:53 p.m.)
Review request for mesos, Adam B and Ben Mahler.
Changes
-------
added better working_dir example
fixed line length style issue
fixed a bug on the attribute flag
Repository: mesos-git
Description
-------
The --help on master and slave have a number of issues which are resolved with this patch.
1. consistency - Path, Location, Where are all used to describe the path of a directory or file. These are cleaned up.
2. zk path for a file must be file:/// not file://. I get that the last / is part of the path, however without an example it can be confusing to newbies
3. --registration_backoff_factor help refers to a register_backoff_factor value which is incorrect.
4. Attribute's notation really needs an example (which is added).
Diffs (updated)
-----
src/logging/flags.hpp 08101b87e5843e8c8f3a74b87d46138a5ff2a97e
src/master/flags.hpp 32704ce19c20815315b0f6bc4efc535f01c00c30
src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a
src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25
src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb
Diff: https://reviews.apache.org/r/24057/diff/
Testing
-------
style check, compiling and manual review
Thanks,
Ken Sipe
Re: Review Request 24057: Help Flag Cleanup
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/#review49029
-----------------------------------------------------------
Thanks for the cleanup!
src/master/flags.hpp
<https://reviews.apache.org/r/24057/#comment85860>
I'm not sure that /tmp/mesos is a good example as the implication is that it's ok for the data to be wiped with a reboot or other /tmp cleaning process?
What about:
/var/lib/mesos/master
- Ben Mahler
On July 29, 2014, 2:54 p.m., Ken Sipe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24057/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 2:54 p.m.)
>
>
> Review request for mesos, Adam B and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The --help on master and slave have a number of issues which are resolved with this patch.
> 1. consistency - Path, Location, Where are all used to describe the path of a directory or file. These are cleaned up.
> 2. zk path for a file must be file:/// not file://. I get that the last / is part of the path, however without an example it can be confusing to newbies
> 3. --registration_backoff_factor help refers to a register_backoff_factor value which is incorrect.
> 4. Attribute's notation really needs an example (which is added).
>
>
> Diffs
> -----
>
> src/logging/flags.hpp 08101b87e5843e8c8f3a74b87d46138a5ff2a97e
> src/master/flags.hpp 32704ce19c20815315b0f6bc4efc535f01c00c30
> src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a
> src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25
> src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb
>
> Diff: https://reviews.apache.org/r/24057/diff/
>
>
> Testing
> -------
>
> style check, compiling and manual review
>
>
> Thanks,
>
> Ken Sipe
>
>