[GitHub] [ozone] ChenSammi commented on a change in pull request #2725: HDDS-5844. Provide capability to config ratis grpcLogAppender max pending request and log write buffer size

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #2725:
URL: https://github.com/apache/ozone/pull/2725#discussion_r737113523



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -413,7 +415,10 @@ private void setRaftSegmentAndWriteBufferSize(RaftProperties properties) {
     RaftServerConfigKeys.Log.setSegmentSizeMax(properties,
         SizeInBytes.valueOf(raftSegmentSize));
     RaftServerConfigKeys.Log.setWriteBufferSize(properties,
-            SizeInBytes.valueOf(raftSegmentSize));
+        SizeInBytes.valueOf(conf.getObject(DatanodeRatisServerConfig.class)

Review comment:
       Hey @bharatviswa504 , besides the new added properties which can be handled alternatively by adding Ozone prefix, I'd like to seperate the raft log write buffer size with raft log file size. Any specific reason that  these two properties value should use the same value? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org