You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/08 01:54:37 UTC
[PR] feat(broker): filter the broker topology by name and address [rocketmq-dashboard]
yyqdbngt opened a new pull request, #4099:
URL: https://github.com/apache/rocketmq-dashboard/pull/4099
## Summary
Add a search box above the broker topology table that filters the currently loaded brokers by name or address (trim + lowercase substring match, following the certs page `normalizedSearch` pattern). The filter is client-side only — it never refetches from the API. Export exports the filtered rows (what you see is what you export), and the export button is disabled when the filter yields zero broker rows.
## Why
With many brokers in a topology it is hard to locate one instance. Filtering the loaded rows by name/address keeps the change purely front-end and consistent with the existing search UX on the certificates and clients pages.
## Testing
- Local type-check: `cd web && ./node_modules/.bin/tsc -b tsconfig.app.json` → exit 0.
- Server Node 20: `./node_modules/.bin/vitest run src/pages/studio/__tests__/BrokerCluster.test.tsx` → all tests green.
- New tests (existing tests did not cover filtering):
- filters the broker table by broker name;
- filters the broker table by broker address;
- exports only the filtered broker rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(broker): filter the broker topology by name and address [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #4099: feat(broker): filter the broker topology by name and address
URL: https://github.com/apache/rocketmq-dashboard/pull/4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org