You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/21 12:15:32 UTC

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12309: KAFKA-14007: Invoking connect headers.close method on shutdown

vamossagar12 commented on code in PR #12309:
URL: https://github.com/apache/kafka/pull/12309#discussion_r902544212


##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -282,7 +282,8 @@ public void configure(Map<String, ?> configs, boolean isKey) {
 
     @Override
     public void close() {
-        // do nothing
+        this.serializer.close();
+        this.deserializer.close();

Review Comment:
   Good catch. I missed this one :/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org