You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2025/03/28 08:13:07 UTC
[PR] HDDS-12676. When both minFreeSpace and minFreeSpacePercent are defined then use minFreeSpace. [ozone]
ashishkumar50 opened a new pull request, #8180:
URL: https://github.com/apache/ozone/pull/8180
## What changes were proposed in this pull request?
When both `hdds.datanode.volume.min.free.space` and `hdds.datanode.volume.min.free.space.pecentage` are defined, `hdds.datanode.volume.min.free.space` will be used.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12676
## How was this patch tested?
Update existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2022513848
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -771,15 +771,16 @@ private void validateMinFreeSpace() {
final boolean minFreeSpaceRatioConfigured = minFreeSpaceRatio >= 0;
if (minFreeSpaceConfigured && minFreeSpaceRatioConfigured) {
- LOG.warn("Only one of {}={} and {}={} should be set. With both set, default value ({}) will be used.",
+ LOG.warn("Only one of {}={} and {}={} should be set. With both set, minFreeSpace value will be used.",
Review Comment:
Please add new comment for this behavior in above comment section.
Also, please add the description for key "hdds.datanode.volume.min.free.space.percent", and explain the relationship between "hdds.datanode.volume.min.free.space.percent" and "hdds.datanode.volume.min.free.space" in key description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8180:
URL: https://github.com/apache/ozone/pull/8180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2023367098
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -73,10 +73,17 @@ public class DatanodeConfiguration extends ReconfigurableConfig {
"hdds.datanode.disk.check.min.gap";
public static final String DISK_CHECK_TIMEOUT_KEY =
"hdds.datanode.disk.check.timeout";
+
+ // Minimum space should be left on volume.
+ // Ex: If volume has 1000GB and minFreeSpace is configured as 10GB,
+ // In this case when availableSpace is 990GB or below, volume is assumed as full
Review Comment:
Ya updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2022502853
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -771,15 +771,16 @@ private void validateMinFreeSpace() {
final boolean minFreeSpaceRatioConfigured = minFreeSpaceRatio >= 0;
if (minFreeSpaceConfigured && minFreeSpaceRatioConfigured) {
- LOG.warn("Only one of {}={} and {}={} should be set. With both set, default value ({}) will be used.",
+ LOG.warn("Only one of {}={} and {}={} should be set. With both set, minFreeSpace value will be used.",
Review Comment:
minFreeSpace -> {}, please use property name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2022612940
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -771,15 +771,16 @@ private void validateMinFreeSpace() {
final boolean minFreeSpaceRatioConfigured = minFreeSpaceRatio >= 0;
if (minFreeSpaceConfigured && minFreeSpaceRatioConfigured) {
- LOG.warn("Only one of {}={} and {}={} should be set. With both set, default value ({}) will be used.",
+ LOG.warn("Only one of {}={} and {}={} should be set. With both set, minFreeSpace value will be used.",
Review Comment:
Updated description, log and comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2023072830
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -73,10 +73,17 @@ public class DatanodeConfiguration extends ReconfigurableConfig {
"hdds.datanode.disk.check.min.gap";
public static final String DISK_CHECK_TIMEOUT_KEY =
"hdds.datanode.disk.check.timeout";
+
+ // Minimum space should be left on volume.
+ // Ex: If volume has 1000GB and minFreeSpace is configured as 10GB,
+ // In this case when availableSpace is 990GB or below, volume is assumed as full
Review Comment:
> `when availableSpace is 990GB or below, volume is assumed as full`
This doesn't sound right. Volume is full if `availableSpace <= 10GB`, or `usedSpace >= 990GB`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12676. Prefer minFreeSpace if minFreeSpacePercent is also defined [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8180:
URL: https://github.com/apache/ozone/pull/8180#issuecomment-2772216281
Thanks @ashishkumar50 for the patch, @ChenSammi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org