You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Monica Song (Jira)" <ji...@apache.org> on 2020/09/21 22:04:00 UTC
[jira] [Commented] (BEAM-10922) Coder is not verified as
deterministic in ApproximateUnique.java
[ https://issues.apache.org/jira/browse/BEAM-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199687#comment-17199687 ]
Monica Song commented on BEAM-10922:
------------------------------------
Although all the unit tests use doubles as their input, and the DoubleCoder is not deterministic...
> Coder is not verified as deterministic in ApproximateUnique.java
> ----------------------------------------------------------------
>
> Key: BEAM-10922
> URL: https://issues.apache.org/jira/browse/BEAM-10922
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Monica Song
> Assignee: Monica Song
> Priority: P2
>
> Calling input.getCoder() does not verify that the coder is deterministic. A possible example where this could present a problem is if the user's data is float, as the float coder is not deterministic [1].
> [1] https://github.com/apache/beam/blob/4d7df122ca053828bd2c7dffa9f390ba2bd8678e/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/FloatCoder.java#L70
--
This message was sent by Atlassian Jira
(v8.3.4#803005)