You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/02/07 20:01:26 UTC

Re: Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62799/
-----------------------------------------------------------

(Updated Feb. 7, 2018, 8:01 p.m.)


Review request for mesos, Joseph Wu and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-8056
    https://issues.apache.org/jira/browse/MESOS-8056


Repository: mesos


Description
-------

We expect the I/O switchboard process to last across agent restarts
(similar to log rotate process or executor processes). Therefore, we
should put it into 'mesos_executor.slice' like others.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp aeb0b3e4cf75b19efd9b3922cc46666707d3c5cb 


Diff: https://reviews.apache.org/r/62799/diff/2/

Changes: https://reviews.apache.org/r/62799/diff/1-2/


Testing
-------

sudo make check


Thanks,

Jie Yu


Re: Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62799/#review197208
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Feb. 7, 2018, 8:01 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62799/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 8:01 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: MESOS-8056
>     https://issues.apache.org/jira/browse/MESOS-8056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We expect the I/O switchboard process to last across agent restarts
> (similar to log rotate process or executor processes). Therefore, we
> should put it into 'mesos_executor.slice' like others.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp aeb0b3e4cf75b19efd9b3922cc46666707d3c5cb 
> 
> 
> Diff: https://reviews.apache.org/r/62799/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>