[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #296: Httpcore 682 master

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #296:
URL: https://github.com/apache/httpcomponents-core/pull/296#discussion_r667692224



##########
File path: httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java
##########
@@ -27,6 +27,19 @@
 
 package org.apache.hc.core5.ssl;
 
+import org.apache.hc.core5.util.Timeout;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Test;
+
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLException;

Review comment:
       @veselov Please avoid moving imports around. It just causes unnecessary noice in the chanage-set. Looks good otherwise.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org