You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/06/09 19:46:05 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
ganeshmurthy opened a new pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253
…e in http2 adaptor. Also made raw_closed_write and raw_closed_read as atomics in tcp_adaptor"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234648
##########
File path: include/qpid/dispatch/atomic.h
##########
@@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref)
#endif
+#define SET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1)
Review comment:
Introduced a CLEAR_ATOMIC_FLAG macro and the http adaptor now uses it to clear the flags once a new connection to the server is established.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234955
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e, qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress ((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+ sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Re-init was wrong. Now uses CLEAR_ATOMIC_FLAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651207009
##########
File path: include/qpid/dispatch/atomic.h
##########
@@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref)
#endif
+#define SET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1)
Review comment:
Why not a CLEAR_ATOMIC_FLAG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651216579
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e, qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress ((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+ sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Why re-init? Won't this destroy the existing state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org