[jira] [Commented] (CURATOR-73) No reliable way to restart leadership in LeaderSelector when connection fails due to edge cases

["Henrik Nordvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900241#comment-13900241 ] 

Henrik Nordvik commented on CURATOR-73:
---------------------------------------

Regarding the test case. It seemed flaky at first, but when I added one additional sleep it works better:
{code}
timing.sleepABit();
timing.sleepABit();
{code}

> No reliable way to restart leadership in LeaderSelector when connection fails due to edge cases
> -----------------------------------------------------------------------------------------------
>
>                 Key: CURATOR-73
>                 URL: https://issues.apache.org/jira/browse/CURATOR-73
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.3.0
>            Reporter: Henrik Nordvik
>         Attachments: CURATOR-73.patch
>
>
> This is related to CURATOR-54, and possibly also CURATOR-62.
> If a LeaderSelector-thread is cancelled (e.g. because of lost connection to zookeeper), there is no way of restarting it. 
> First it jumps out of the doWork-loop, because the interrupt flag is set.
> The isQueued flag is not reset when this happens, so requeue() does nothing, even though the thread has been parked.
> I'm using curator 2.3.0 with the new ListenerAdapter-way of handling stateChange().



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)