You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/05/16 22:27:20 UTC
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175168
-----------------------------------------------------------
I personally don't like using an RC version. We should update protobuf to an official release, say 3.3.1?
- Chun-Hung Hsiao
On April 25, 2017, 10:51 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58358/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 10:51 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
> - On a Mac OS, download and untar protobuf v3.2.0 source at
> https://github.com/google/protobuf/archive/v3.2.0rc2.tar.gz;
> - Run `./autogen.sh`;
> - Recompress and tar by `tar -czvf`.
>
> Note that reviewboard seems to have problem for uploading/dowloading binary patches, so this particular commit is also available at https://github.com/apache/mesos/pull/208
>
>
> Diffs
> -----
>
> 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
> 3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58358/diff/4/
>
>
> Testing
> -------
>
> 1. make check;
> 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
> 3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.
Posted by Neil Conway <ne...@gmail.com>.
> On May 16, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> > I personally don't like using an RC version. We should update protobuf to an official release, say 3.3.1?
>
> Zhitao Li wrote:
> IIRC the rc2 tar was what's available when I looked at the download page. It seems like they have fixed the symlink, so I can download this one more time and get it updated, although I don't expect any difference.
>
> For version, 3.3.x was not yet available when we looked at this. Now that it's out, I'm personall okay if we want to go with latest, although it seems like all issues between 3.2 and 3.3 is not critical to us?
>
> Chun-Hung Hsiao wrote:
> 3.2.x should be fine. I just looked up what's the difference between 3.2.0 and 3.2.1. It seems that there're some fixes for ruby, objective-c and its CLI. Probably nothing critical.
If we are going to update the vendored protobuf, I think we should update to the latest stable release (3.3.0 it seems). Protobuf 3.3.0 includes various fixes for C++ support, which would be nice to pickup.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175168
-----------------------------------------------------------
On May 17, 2017, 3:45 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58358/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 3:45 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
> - On a Mac OS, download and untar protobuf v3.2.0 source at
> https://github.com/google/protobuf/archive/v3.2.0.tar.gz;
> - Run `./autogen.sh`;
> - Recompress and tar by `tar -czvf`.
>
>
> Diffs
> -----
>
> 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
> 3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58358/diff/5/
>
>
> Testing
> -------
>
> 1. make check;
> 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
> 3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.
Posted by Zhitao Li <zh...@gmail.com>.
> On May 16, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> > I personally don't like using an RC version. We should update protobuf to an official release, say 3.3.1?
IIRC the rc2 tar was what's available when I looked at the download page. It seems like they have fixed the symlink, so I can download this one more time and get it updated, although I don't expect any difference.
For version, 3.3.x was not yet available when we looked at this. Now that it's out, I'm personall okay if we want to go with latest, although it seems like all issues between 3.2 and 3.3 is not critical to us?
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175168
-----------------------------------------------------------
On April 25, 2017, 10:51 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58358/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 10:51 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
> - On a Mac OS, download and untar protobuf v3.2.0 source at
> https://github.com/google/protobuf/archive/v3.2.0rc2.tar.gz;
> - Run `./autogen.sh`;
> - Recompress and tar by `tar -czvf`.
>
> Note that reviewboard seems to have problem for uploading/dowloading binary patches, so this particular commit is also available at https://github.com/apache/mesos/pull/208
>
>
> Diffs
> -----
>
> 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
> 3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58358/diff/4/
>
>
> Testing
> -------
>
> 1. make check;
> 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
> 3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On May 16, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> > I personally don't like using an RC version. We should update protobuf to an official release, say 3.3.1?
>
> Zhitao Li wrote:
> IIRC the rc2 tar was what's available when I looked at the download page. It seems like they have fixed the symlink, so I can download this one more time and get it updated, although I don't expect any difference.
>
> For version, 3.3.x was not yet available when we looked at this. Now that it's out, I'm personall okay if we want to go with latest, although it seems like all issues between 3.2 and 3.3 is not critical to us?
3.2.x should be fine. I just looked up what's the difference between 3.2.0 and 3.2.1. It seems that there're some fixes for ruby, objective-c and its CLI. Probably nothing critical.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/#review175168
-----------------------------------------------------------
On May 17, 2017, 3:45 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58358/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 3:45 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
> - On a Mac OS, download and untar protobuf v3.2.0 source at
> https://github.com/google/protobuf/archive/v3.2.0.tar.gz;
> - Run `./autogen.sh`;
> - Recompress and tar by `tar -czvf`.
>
>
> Diffs
> -----
>
> 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06
> 3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58358/diff/5/
>
>
> Testing
> -------
>
> 1. make check;
> 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade between this chain and Mesos 1.2;
> 3. build this branch in Apache Aurora's vagrant based box, and verifies that Aurora scheduler (using java) and executor (using python) still works with `libmesos.so` built from this branch.
>
>
> Thanks,
>
> Zhitao Li
>
>