You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/22 23:34:14 UTC

Review Request 70284: Cleanup volume and storage pool listing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70284/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Bugs: MESOS-9622
    https://issues.apache.org/jira/browse/MESOS-9622


Repository: mesos


Description
-------

This patch modified SLRP's volume and storage pool listing methods to
conform to `VolumeManager`s public interface. They will be moved out
from SLRP to v0 `VolumeManager` later.


Diffs
-----

  src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93 


Diff: https://reviews.apache.org/r/70284/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 70284: Cleanup volume and storage pool listing.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70284/
-----------------------------------------------------------

(Updated March 27, 2019, 5:59 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-9622
    https://issues.apache.org/jira/browse/MESOS-9622


Repository: mesos


Description
-------

This patch modified SLRP's volume and storage pool listing methods to
conform to `VolumeManager`s public interface. They will be moved out
from SLRP to v0 `VolumeManager` later.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93 


Diff: https://reviews.apache.org/r/70284/diff/2/

Changes: https://reviews.apache.org/r/70284/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 70284: Cleanup volume and storage pool listing.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70284/#review213940
-----------------------------------------------------------



PASS: Mesos patch 70284 was successfully built and tested.

Reviews applied: `['70245', '70168', '70213', '70214', '70216', '70215', '70217', '70284']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3002/mesos-review-70284

- Mesos Reviewbot Windows


On March 22, 2019, 11:34 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70284/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 11:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modified SLRP's volume and storage pool listing methods to
> conform to `VolumeManager`s public interface. They will be moved out
> from SLRP to v0 `VolumeManager` later.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93 
> 
> 
> Diff: https://reviews.apache.org/r/70284/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70284: Cleanup volume and storage pool listing.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70284/#review214047
-----------------------------------------------------------


Ship it!




Nice, readable cleanup.

- Benjamin Bannier


On March 23, 2019, 12:34 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70284/
> -----------------------------------------------------------
> 
> (Updated March 23, 2019, 12:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modified SLRP's volume and storage pool listing methods to
> conform to `VolumeManager`s public interface. They will be moved out
> from SLRP to v0 `VolumeManager` later.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93 
> 
> 
> Diff: https://reviews.apache.org/r/70284/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>