You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/27 16:54:44 UTC
[GitHub] [flink] zentol opened a new pull request, #19597: [FLINK-27431][rpc] Allow RpcTimeouts to be specified as Duration
zentol opened a new pull request, #19597:
URL: https://github.com/apache/flink/pull/19597
To support the gradual migration of components to Duration we should allow the RpcTimeout annotation to also be used for Duration timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #19597: [FLINK-27431][rpc] Allow RpcTimeouts to be specified as Duration
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #19597:
URL: https://github.com/apache/flink/pull/19597#discussion_r860527912
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/TimeoutCallStackTest.java:
##########
@@ -77,9 +79,19 @@ void stopTestEndpoints() {
@Test
void testTimeoutException() throws Exception {
Review Comment:
```suggestion
void testTimeoutExceptionWithTime() throws Exception {
```
nit: Can we make this test as descriptive as the other one?
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/TimeoutCallStackTest.java:
##########
@@ -77,9 +79,19 @@ void stopTestEndpoints() {
@Test
void testTimeoutException() throws Exception {
+ txestTimeoutException(gateway -> gateway.callThatTimesOut(Time.milliseconds(1)));
+ }
+
+ @Test
+ void testTimeoutExceptionWithDuration() throws Exception {
+ txestTimeoutException(gateway -> gateway.callThatTimesOut(Duration.ofMillis(1)));
+ }
+
+ private void txestTimeoutException(
Review Comment:
```suggestion
private void testTimeoutException(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19597: [FLINK-27431][rpc] Allow RpcTimeouts to be specified as Duration
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19597:
URL: https://github.com/apache/flink/pull/19597#issuecomment-1111244646
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "341fb490a9c62e19d93fe9334d7de4802a34bc32",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "341fb490a9c62e19d93fe9334d7de4802a34bc32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 341fb490a9c62e19d93fe9334d7de4802a34bc32 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19597: [FLINK-27431][rpc] Allow RpcTimeouts to be specified as Duration
Posted by GitBox <gi...@apache.org>.
zentol merged PR #19597:
URL: https://github.com/apache/flink/pull/19597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org