You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2023/06/01 14:33:00 UTC

[jira] [Updated] (CASSANDRA-12937) Default setting (yaml) for SSTable compression

     [ https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Miklosovic updated CASSANDRA-12937:
------------------------------------------
    Authors: Claude Warren, Stefan Miklosovic  (was: Stefan Miklosovic)
     Status: Patch Available  (was: In Progress)

I finally fixed it all. Phew, what a ride! I reorganized the branch in such a way that there is one commit which implements it and another one where tests are done so it is nicely visible and easier to contemplate about.

I think we are finally in a good shape to have a look of the second committer. 

[~mck] would you take a look, please?

[~claude] no worries you will be still author of the PR, I do that upon actual commit once we get there, I just squashed / reorganized the commits little bit for now.

PR: https://github.com/apache/cassandra/pull/2282
j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2353/workflows/aa9ee549-ec99-455f-8e89-b325e013ff8e



> Default setting (yaml) for SSTable compression
> ----------------------------------------------
>
>                 Key: CASSANDRA-12937
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Config
>            Reporter: Michael Semb Wever
>            Assignee: Stefan Miklosovic
>            Priority: Low
>              Labels: AdventCalendar2021, lhf
>             Fix For: 5.x
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> In many situations the choice of compression for sstables is more relevant to the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable compression that new tables will inherit (instead of the defaults found in {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly compression (btrfs, zfs) or specific disk configurations or even specific C* versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying the field required for defining the default compression parameters. In {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for the default compression. This field should be initialized in {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where {{CompressionParams.DEFAULT}} was used the code should call {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test that the table schema use the new default when a new table is created (see CreateTest for some example).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org