You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by Thiago Veronezi <th...@veronezi.org> on 2010/08/06 21:25:47 UTC

new patches for review

Hi devs,
I've uploaded new patches for some EJB3.1 features...

https://issues.apache.org/jira/browse/OPENEJB-1144
https://issues.apache.org/jira/browse/OPENEJB-1146
https://issues.apache.org/jira/browse/OPENEJB-1151

When you have time, code-review these guys for me, please.
[]s,
Thiago.

Re: new patches for review

Posted by Thiago Veronezi <th...@veronezi.org>.

Done... Sorry, Jean-Louis.
[]s,
Thiago

On Thu, Aug 19, 2010 at 10:35 AM, Jean-Louis MONTEIRO <
jean-louis.monteiro@atosorigin.com> wrote:

>
> Thiago,
>
> can you please attach new patches using an absolute path?
> Actually, the patch format is eclipse specific and difficult to use in
> other
> IDE or using the command line tool patch.
>
> By the way, you can do that with eclipse if you prefer. You just need to
> select the root project (openejb parent module) and then use selection
> instead of the default workspace.
>
> Thanks.
> Jean-Louis
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2331295.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: new patches for review

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.

Thiago,

can you please attach new patches using an absolute path?
Actually, the patch format is eclipse specific and difficult to use in other
IDE or using the command line tool patch.

By the way, you can do that with eclipse if you prefer. You just need to
select the root project (openejb parent module) and then use selection
instead of the default workspace.

Thanks.
Jean-Louis
-- 
View this message in context: http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2331295.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: new patches for review

Posted by Thiago Veronezi <th...@veronezi.org>.

On Fri, Aug 20, 2010 at 10:41 AM, Jean-Louis MONTEIRO <
jean-louis.monteiro@atosorigin.com> wrote:

>
> No problem Jarek.
> I was actually starting working on, but I have some doubts regarding the
> spec.
>
> @Thiago, @Jarek:
> - what's your understanding regarding the spec? I mean do we need to call
> remove methods, etc (see StatefulContainer#timedOut method )?
>
Hmmmm... nice catch: Yes, I think so. :O)


>
> - regarding a Gurkan's post, is it relevant to create deamon threads only?
>
I didnt check the cache yet. The idea about using the thread is to remove
the bean as soon as it is timedout by using the ScheduledExecutorService
object. Here, I'm not sure about how to manage the number of threads.


> - after creating a new Instance, shouldn't be necessary to have a timeout
> set before calling #scheduleRelease?
>
The timeout value should come from the CoreDeploymentInfo object. I
just realized that my testCase is not testing the default StatefulTimeout
value (from spec: "If a stateful session bean timeout is not designated
using this standard metadata, the container determines when to end the
lifetime of the bean, possibly based on vendor-specific configuration.")

tkx, Jean-Louis!

[]s,
Thiago.

Re: new patches for review

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.

No problem Jarek. 
I was actually starting working on, but I have some doubts regarding the
spec.

@Thiago, @Jarek: 
- what's your understanding regarding the spec? I mean do we need to call
remove methods, etc (see StatefulContainer#timedOut method )?

- regarding a Gurkan's post, is it relevant to create deamon threads only?

- after creating a new Instance, shouldn't be necessary to have a timeout
set before calling #scheduleRelease?


Anyway, thanks Thiago. It was interesting digging on that topic.

Jean-Louis





Jarek Gawor wrote:
> 
> Thiago, Jean-Louis,
> 
> I will work on OPENEJB-1146 since I started working on it before I saw
> the patch. I'll try to combine our solutions.
> 
> Jarek
> 

-- 
View this message in context: http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2332580.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: new patches for review

Posted by Thiago Veronezi <th...@veronezi.org>.

Ok... tkx.
[]s,
Thiago.

On Fri, Aug 20, 2010 at 10:30 AM, Jarek Gawor <jg...@gmail.com> wrote:

> Thiago, Jean-Louis,
>
> I will work on OPENEJB-1146 since I started working on it before I saw
> the patch. I'll try to combine our solutions.
>
> Jarek
>
> On Thu, Aug 19, 2010 at 6:52 AM, Jean-Louis MONTEIRO
> <je...@atosorigin.com> wrote:
> >
> > Hi Thiago,
> >
> > Apologize if we have been too slow to review your patches.
> > I nobody else gave it a shoot, i can start working a bit on them this
> > afternoon.
> >
> > Jean-Louis
> >
> >
> >
> > Thiago Veronezi-3 wrote:
> >>
> >> Hi devs,
> >> I've uploaded new patches for some EJB3.1 features...
> >>
> >> https://issues.apache.org/jira/browse/OPENEJB-1144
> >> https://issues.apache.org/jira/browse/OPENEJB-1146
> >> https://issues.apache.org/jira/browse/OPENEJB-1151
> >>
> >> When you have time, code-review these guys for me, please.
> >> []s,
> >> Thiago.
> >>
> >>
> >
> > --
> > View this message in context:
> http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2330980.html
> > Sent from the OpenEJB Dev mailing list archive at Nabble.com.
> >
>

Re: new patches for review

Posted by Jarek Gawor <jg...@gmail.com>.

Thiago, Jean-Louis,

I will work on OPENEJB-1146 since I started working on it before I saw
the patch. I'll try to combine our solutions.

Jarek

On Thu, Aug 19, 2010 at 6:52 AM, Jean-Louis MONTEIRO
<je...@atosorigin.com> wrote:
>
> Hi Thiago,
>
> Apologize if we have been too slow to review your patches.
> I nobody else gave it a shoot, i can start working a bit on them this
> afternoon.
>
> Jean-Louis
>
>
>
> Thiago Veronezi-3 wrote:
>>
>> Hi devs,
>> I've uploaded new patches for some EJB3.1 features...
>>
>> https://issues.apache.org/jira/browse/OPENEJB-1144
>> https://issues.apache.org/jira/browse/OPENEJB-1146
>> https://issues.apache.org/jira/browse/OPENEJB-1151
>>
>> When you have time, code-review these guys for me, please.
>> []s,
>> Thiago.
>>
>>
>
> --
> View this message in context: http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2330980.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: new patches for review

Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.

Hi Thiago,

Apologize if we have been too slow to review your patches.
I nobody else gave it a shoot, i can start working a bit on them this
afternoon.

Jean-Louis



Thiago Veronezi-3 wrote:
> 
> Hi devs,
> I've uploaded new patches for some EJB3.1 features...
> 
> https://issues.apache.org/jira/browse/OPENEJB-1144
> https://issues.apache.org/jira/browse/OPENEJB-1146
> https://issues.apache.org/jira/browse/OPENEJB-1151
> 
> When you have time, code-review these guys for me, please.
> []s,
> Thiago.
> 
> 

-- 
View this message in context: http://openejb.979440.n4.nabble.com/new-patches-for-review-tp2316734p2330980.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.