You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by aheritier <gi...@git.apache.org> on 2017/01/31 09:27:19 UTC
[GitHub] maven pull request #104: [MNG-5961] Fix the SLF4J logger factory implementat...
GitHub user aheritier opened a pull request:
https://github.com/apache/maven/pull/104
[MNG-5961] Fix the SLF4J logger factory implementation used for LOG4J2
This is the fix I did in https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blobdiff;f=maven-embedder/src/main/resources/META-INF/maven/slf4j-configuration.properties;h=cd01f9e6bb29cf31371e0e6df04d095430d3ea9b;hp=87418363b1812e85d6a41a63df4486d07227e1d5;hb=202f757af3aba6e1b96631de025e0ba692098009;hpb=5a3332ca347628605bec7d3e9f9309081aaba46c
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aheritier/maven patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit 0055ac0b4b572fa0e8bf699327ea45263ce40e81
Author: Arnaud Heritier <ah...@apache.org>
Date: 2017-01-31T09:26:28Z
[MNG-5961] Fix the SLF4J logger factory implementation used for LOG4J2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by aheritier <gi...@git.apache.org>.
Github user aheritier commented on the issue:
https://github.com/apache/maven/pull/104
Cool @michael-o it is exactly what I did
the build is in progress
https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-5961/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/104
Do this:
git checkout master
git checkout -b MNG-5961
git cherry-pick <your-sha1>
git push
Wait for the Jenkins build to finish, get approval
git checkout master
git merge MNG-5961
Delete branch locally and remote.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by aheritier <gi...@git.apache.org>.
Github user aheritier commented on the issue:
https://github.com/apache/maven/pull/104
I think @stephenc will tell me to push a branch on ASF side :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by stephenc <gi...@git.apache.org>.
Github user stephenc commented on the issue:
https://github.com/apache/maven/pull/104
> we don't have a CI validation here
Yep waiting to get SCM API 2.0.x back into the uc and then pester infra to upgrade
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/104
I am fine with this PR. You have to raise the issue on the dev mailing list to have at least someone who seconds it. If someone does, after your branch passes all tests, go ahead and merge into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request #104: [MNG-5961] Fix the SLF4J logger factory implementat...
Posted by aheritier <gi...@git.apache.org>.
Github user aheritier closed the pull request at:
https://github.com/apache/maven/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by aheritier <gi...@git.apache.org>.
Github user aheritier commented on the issue:
https://github.com/apache/maven/pull/104
cc @michael-o @stephenc
https://issues.apache.org/jira/browse/MNG-5961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...
Posted by aheritier <gi...@git.apache.org>.
Github user aheritier commented on the issue:
https://github.com/apache/maven/pull/104
@michael-o we don't have a CI validation here, thus I have to open a real branch on ASF side. Right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org