[GitHub] mcvsubbu commented on issue #3721: Add metric to capture max queries per 10s seen in the last minute

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #3721: Add metric to capture max queries per 10s seen in the last minute
URL: https://github.com/apache/incubator-pinot/pull/3721#issuecomment-456190291
 
 
   At the minimum, use the HitCounter class (reconfigured to suit the time interval you need) to measure the peak qps.
   At best, we should be able to re-use the QueryQuota processing classes. 
   Currently, the query quota management classes seem to have 2 entries per table -- one for realtime and one for offine. Effectively, the min of the two query quotas is applied for the table. Instead, we can set the rate limiter config to be the min of the two tables (if they are both configured). It makes config update logic a little more complex, but the mainline processing much simpler, where the map is maintained on a per-table with rawtable name as the key. i am not sure what made us choose the 2-table config management in the initial implementation, so let us dig into that and see if that can be re-used in its entirety by using a single  rate limiter per table.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org