You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Justin Mclean <jm...@apache.org> on 2021/06/10 00:14:55 UTC
Re: [VOTE] Release Apache Wicket 9.3.0
Hi,
I'm not on your PMC but I took a quick look at this release and noticed that the contents of LICENSE and NOTICE don't follow the guidance here. [1] In particular included 3rd party licenses are not listed in LICENSE and the NOTICE file contains MIT and BSD license information when it probably shouldn't. there might however be a reason you are doing it this way that I'm not aware of.
I can also see some fonts in your release that may not be under a license that is compatible with the Apache license.
You might want to review these couple of things next time you make a release.
Kind Regards,
Justin
1. https://infra.apache.org/licensing-howto.html
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Martin Grigorov <mg...@apache.org>.
On Sat, Jun 12, 2021 at 1:25 AM Lon Varscsak <lo...@gmail.com> wrote:
> It was a documented case, here's what Sven told me several years ago (maybe
> it has since been "fixed"):
>
> "this is a known problem with TransparentWebMarkupContainers, see
> > WICKET-5479
>
WICKET-5479 is about Enclosure. Yes, we know that Enclosures have problems!
As I recommended in the ticket you better use EnclosureContainer instead of
<div wicket:enclosure> or <wicket:enclosure>
> > You should use a WebMarkupContainer and #queue() instead."
>
>
> I can create a test case though.
>
If you have a test case without Enclosure then please share it and explain
what problem you face!
>
> On Thu, Jun 10, 2021 at 11:31 PM Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi Lon,
> >
> > On Fri, Jun 11, 2021 at 7:08 AM Lon Varscsak <lo...@gmail.com>
> > wrote:
> >
> > > I find it useful as well. Also, there is a situation where queue is
> > > required (as far as I can tell) and that's when you're subclassing
> > > something with <wicket:extend> doing an "add" on the subclass throws an
> > > error because it can't be found in markup. "queue" makes that
> situation
> > > work. Maybe there's another way to handle that...I'm not sure.
> > >
> >
> > This should just work with add().
> > If you can reproduce it then please share it with us and we will take a
> > look!
> >
> >
> > >
> > > -Lon
> > >
> > > On Wed, Jun 9, 2021 at 5:14 PM Justin Mclean <jm...@apache.org>
> wrote:
> > >
> > > > Hi,
> > > >
> > > > I'm not on your PMC but I took a quick look at this release and
> noticed
> > > > that the contents of LICENSE and NOTICE don't follow the guidance
> here.
> > > [1]
> > > > In particular included 3rd party licenses are not listed in LICENSE
> and
> > > the
> > > > NOTICE file contains MIT and BSD license information when it probably
> > > > shouldn't. there might however be a reason you are doing it this way
> > > that
> > > > I'm not aware of.
> > > >
> > > > I can also see some fonts in your release that may not be under a
> > license
> > > > that is compatible with the Apache license.
> > > >
> > > > You might want to review these couple of things next time you make a
> > > > release.
> > > >
> > > > Kind Regards,
> > > > Justin
> > > >
> > > > 1. https://infra.apache.org/licensing-howto.html
> > > >
> > >
> >
>
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Lon Varscsak <lo...@gmail.com>.
It was a documented case, here's what Sven told me several years ago (maybe
it has since been "fixed"):
"this is a known problem with TransparentWebMarkupContainers, see
> WICKET-5479
> You should use a WebMarkupContainer and #queue() instead."
I can create a test case though.
On Thu, Jun 10, 2021 at 11:31 PM Martin Grigorov <mg...@apache.org>
wrote:
> Hi Lon,
>
> On Fri, Jun 11, 2021 at 7:08 AM Lon Varscsak <lo...@gmail.com>
> wrote:
>
> > I find it useful as well. Also, there is a situation where queue is
> > required (as far as I can tell) and that's when you're subclassing
> > something with <wicket:extend> doing an "add" on the subclass throws an
> > error because it can't be found in markup. "queue" makes that situation
> > work. Maybe there's another way to handle that...I'm not sure.
> >
>
> This should just work with add().
> If you can reproduce it then please share it with us and we will take a
> look!
>
>
> >
> > -Lon
> >
> > On Wed, Jun 9, 2021 at 5:14 PM Justin Mclean <jm...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > I'm not on your PMC but I took a quick look at this release and noticed
> > > that the contents of LICENSE and NOTICE don't follow the guidance here.
> > [1]
> > > In particular included 3rd party licenses are not listed in LICENSE and
> > the
> > > NOTICE file contains MIT and BSD license information when it probably
> > > shouldn't. there might however be a reason you are doing it this way
> > that
> > > I'm not aware of.
> > >
> > > I can also see some fonts in your release that may not be under a
> license
> > > that is compatible with the Apache license.
> > >
> > > You might want to review these couple of things next time you make a
> > > release.
> > >
> > > Kind Regards,
> > > Justin
> > >
> > > 1. https://infra.apache.org/licensing-howto.html
> > >
> >
>
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Martin Grigorov <mg...@apache.org>.
Hi Lon,
On Fri, Jun 11, 2021 at 7:08 AM Lon Varscsak <lo...@gmail.com> wrote:
> I find it useful as well. Also, there is a situation where queue is
> required (as far as I can tell) and that's when you're subclassing
> something with <wicket:extend> doing an "add" on the subclass throws an
> error because it can't be found in markup. "queue" makes that situation
> work. Maybe there's another way to handle that...I'm not sure.
>
This should just work with add().
If you can reproduce it then please share it with us and we will take a
look!
>
> -Lon
>
> On Wed, Jun 9, 2021 at 5:14 PM Justin Mclean <jm...@apache.org> wrote:
>
> > Hi,
> >
> > I'm not on your PMC but I took a quick look at this release and noticed
> > that the contents of LICENSE and NOTICE don't follow the guidance here.
> [1]
> > In particular included 3rd party licenses are not listed in LICENSE and
> the
> > NOTICE file contains MIT and BSD license information when it probably
> > shouldn't. there might however be a reason you are doing it this way
> that
> > I'm not aware of.
> >
> > I can also see some fonts in your release that may not be under a license
> > that is compatible with the Apache license.
> >
> > You might want to review these couple of things next time you make a
> > release.
> >
> > Kind Regards,
> > Justin
> >
> > 1. https://infra.apache.org/licensing-howto.html
> >
>
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Lon Varscsak <lo...@gmail.com>.
I find it useful as well. Also, there is a situation where queue is
required (as far as I can tell) and that's when you're subclassing
something with <wicket:extend> doing an "add" on the subclass throws an
error because it can't be found in markup. "queue" makes that situation
work. Maybe there's another way to handle that...I'm not sure.
-Lon
On Wed, Jun 9, 2021 at 5:14 PM Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> I'm not on your PMC but I took a quick look at this release and noticed
> that the contents of LICENSE and NOTICE don't follow the guidance here. [1]
> In particular included 3rd party licenses are not listed in LICENSE and the
> NOTICE file contains MIT and BSD license information when it probably
> shouldn't. there might however be a reason you are doing it this way that
> I'm not aware of.
>
> I can also see some fonts in your release that may not be under a license
> that is compatible with the Apache license.
>
> You might want to review these couple of things next time you make a
> release.
>
> Kind Regards,
> Justin
>
> 1. https://infra.apache.org/licensing-howto.html
>
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> Please share your advices in a ticket. Without more concrete items what could be improved most probably nothing will be done.
I’ve done so, hopefully that helps.
Kind Regards,
Justin
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Martin Grigorov <mg...@apache.org>.
Hi Justin,
On Thu, Jun 10, 2021 at 3:56 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> As I said I not on your PMC so while I could suggest changes they may be
> out of context with your community or ignore history. I think there's some
> work here that needs t be done to comply with the Apache license and ASF
> policy. I am happy to provide advice and review any changes if you need.
>
Please share your advices in a ticket.
Without more concrete items what could be improved most probably nothing
will be done.
Martin
>
> Kind Regards,
> Justin
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
As I said I not on your PMC so while I could suggest changes they may be out of context with your community or ignore history. I think there's some work here that needs t be done to comply with the Apache license and ASF policy. I am happy to provide advice and review any changes if you need.
Kind Regards,
Justin
Re: [VOTE] Release Apache Wicket 9.3.0
Posted by Martin Grigorov <mg...@apache.org>.
Hi Justin,
Thank you for notifying us!
Could you please create an issue at JIRA [1] with more details ?
Or even better a Pull Request [2] with your suggested changes. Thank you!
1. https://issues.apache.org/jira/projects/WICKET
2. https://github.com/apache/wicket/
On Thu, Jun 10, 2021 at 3:15 AM Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> I'm not on your PMC but I took a quick look at this release and noticed
> that the contents of LICENSE and NOTICE don't follow the guidance here. [1]
> In particular included 3rd party licenses are not listed in LICENSE and the
> NOTICE file contains MIT and BSD license information when it probably
> shouldn't. there might however be a reason you are doing it this way that
> I'm not aware of.
>
> I can also see some fonts in your release that may not be under a license
> that is compatible with the Apache license.
>
> You might want to review these couple of things next time you make a
> release.
>
> Kind Regards,
> Justin
>
> 1. https://infra.apache.org/licensing-howto.html
>