You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/11/25 14:19:24 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #356: Improved: redundancy removal (OFBIZ-12404)

PierreSmits opened a new pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356


   modified: InvoiceScreens.xml
   removed redundant property-maps for Party and Product labels from InvoiceOverview
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux edited a comment on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979798722


   Right, but it would not have hurt to have it here too :unamused:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979798722


   Right!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] PierreSmits commented on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979853781


   Jacques, 
   Please consider that this may trigger someone to cry wolf again, as we have seen in recent days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979254339


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=356&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=356) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=356&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979766100


   Hi Pierre,
   
   Even if it obvious for you (once done), it would have been great if you had added that these lines duplicated those in main-decorator (I guess)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
PierreSmits edited a comment on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979853781


   Jacques, 
   Please consider that this may trigger someone to cry wolf again, as we have seen in recent days. Let it go. For harmony (and happy collaborating) sake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ofbiz-framework] PierreSmits commented on pull request #356: Improved: redundancy removal (OFBIZ-12404)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #356:
URL: https://github.com/apache/ofbiz-framework/pull/356#issuecomment-979771265


   Thanks Jacques, for your constructive comment. Context is addressed in the ticket, which will be seen by existing and potential adopters when the release notes are generated for a new release. Context provided in the commit is not referenced there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org