You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/07/03 09:03:35 UTC
Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network offering.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12241/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Tests in test_network_offering.py failed as Vlan option was false. Changed it to true.
Diffs
-----
test/integration/component/test_network_offering.py a3e87f6
Diff: https://reviews.apache.org/r/12241/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network
offering.
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 3, 2013, 11:14 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_network_offering.py, line 61
> > <https://reviews.apache.org/r/12241/diff/1/?file=315244#file315244line61>
> >
> > There is a different issue here.
> >
> > specifyVlan=false is the default behaviour of the API. But the network used for creation specifies the vlan. The test should be for creating the most basic network out of a standard network offering where specifyVlan=false and no vlan is given.
> >
> > The test case for specifying a vlan should be separated.
See related CLOUDSTACK-3348 for the issue happening when you create a network with specifyVlan=false
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12241/#review22705
-----------------------------------------------------------
On July 3, 2013, 7:03 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12241/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Tests in test_network_offering.py failed as Vlan option was false. Changed it to true.
>
>
> Diffs
> -----
>
> test/integration/component/test_network_offering.py a3e87f6
>
> Diff: https://reviews.apache.org/r/12241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network
offering.
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 3, 2013, 11:14 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_network_offering.py, line 61
> > <https://reviews.apache.org/r/12241/diff/1/?file=315244#file315244line61>
> >
> > There is a different issue here.
> >
> > specifyVlan=false is the default behaviour of the API. But the network used for creation specifies the vlan. The test should be for creating the most basic network out of a standard network offering where specifyVlan=false and no vlan is given.
> >
> > The test case for specifying a vlan should be separated.
>
> Prasanna Santhanam wrote:
> See related CLOUDSTACK-3348 for the issue happening when you create a network with specifyVlan=false
Fixed these issues with the following. I'll discard this review.
Please reopen if you find any problem below:
commit 9d07f899c8dcf24a6f96dc2e2a2a3f3e256582b8
Author: Prasanna Santhanam <ts...@apache.org>
Date: Wed Jul 3 17:10:53 2013 +0530
separate the shared network test for network offerings
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
commit 04d9d209adae5bc2231c854f694238db8feb0057
Author: Prasanna Santhanam <ts...@apache.org>
Date: Wed Jul 3 17:03:39 2013 +0530
Removing the vlan selection in network offering test
Also do not wait for cleanup. Just send cleanup to server and proceed
further.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12241/#review22705
-----------------------------------------------------------
On July 3, 2013, 7:03 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12241/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Tests in test_network_offering.py failed as Vlan option was false. Changed it to true.
>
>
> Diffs
> -----
>
> test/integration/component/test_network_offering.py a3e87f6
>
> Diff: https://reviews.apache.org/r/12241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network
offering.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12241/#review22705
-----------------------------------------------------------
test/integration/component/test_network_offering.py
<https://reviews.apache.org/r/12241/#comment46407>
There is a different issue here.
specifyVlan=false is the default behaviour of the API. But the network used for creation specifies the vlan. The test should be for creating the most basic network out of a standard network offering where specifyVlan=false and no vlan is given.
The test case for specifying a vlan should be separated.
- Prasanna Santhanam
On July 3, 2013, 7:03 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12241/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Tests in test_network_offering.py failed as Vlan option was false. Changed it to true.
>
>
> Diffs
> -----
>
> test/integration/component/test_network_offering.py a3e87f6
>
> Diff: https://reviews.apache.org/r/12241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network
offering.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12241/#review22703
-----------------------------------------------------------
Ship it!
Ship It!
- daan Hoogland
On July 3, 2013, 7:03 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12241/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Tests in test_network_offering.py failed as Vlan option was false. Changed it to true.
>
>
> Diffs
> -----
>
> test/integration/component/test_network_offering.py a3e87f6
>
> Diff: https://reviews.apache.org/r/12241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>