[GitHub] [superset] hughhhh commented on a diff in pull request #20880: fix: Save dataset + chart when Chart source is Query

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #20880:
URL: https://github.com/apache/superset/pull/20880#discussion_r932756691


##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -145,6 +166,44 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
       dashboard_title: string;
     };
 
+    if (this.props.datasource?.type === DatasourceType.Query) {

Review Comment:
   i'd rather use positive logic here, and un sure we'd want the same pattern for other datasource types as we continue integrate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org