You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "youngkermit8-coder (via GitHub)" <gi...@apache.org> on 2026/08/11 10:31:24 UTC

[PR] [Studio][ISSUE #1694] Label mock Grafana bulk exports as JSON [rocketmq-dashboard]

youngkermit8-coder opened a new pull request, #1717:
URL: https://github.com/apache/rocketmq-dashboard/pull/1717

   ## What changed
   
   - Return bulk Grafana exports together with their intended filename.
   - Emit mock-mode bundles as `application/json` with a `.json` filename.
   - Preserve the real backend ZIP blob and `.zip` filename.
   - Make the download component use the filename supplied by the service.
   - Cover mock JSON, real ZIP, and component download filename behavior.
   
   ## Why
   
   Mock mode serialized the dashboard bundle with `JSON.stringify`, but labeled and downloaded those bytes as a ZIP archive. Archive tools therefore reported the demo export as corrupt even though its JSON content was valid.
   
   ## Impact
   
   Mock users now receive a valid JSON download, while real deployments continue receiving the server-generated ZIP archive unchanged.
   
   ## Validation
   
   - Related service and component tests: 2 files, 14 tests passed
   - ESLint on all four changed files: passed
   - Prettier check on all four changed files: passed
   - `npm run build`: passed
   - Full repository ESLint still reports the two existing `react-hooks/set-state-in-effect` baseline errors in `pages/instance/consumer.tsx`; this PR does not modify that file
   
   Refs #1694
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Studio][ISSUE #1694] Label mock Grafana bulk exports as JSON [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1717:
URL: https://github.com/apache/rocketmq-dashboard/pull/1717#issuecomment-5280035632

   Consolidated into #1946 as part of the batch consolidation of @youngkermit8-coder's frontend PRs (merged into rocketmq-studio). The change is preserved in the merged commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Studio][ISSUE #1694] Label mock Grafana bulk exports as JSON [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1717: [Studio][ISSUE #1694] Label mock Grafana bulk exports as JSON
URL: https://github.com/apache/rocketmq-dashboard/pull/1717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org