You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/15 09:52:53 UTC
[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #1000: nimble/host: Remove redundant check in connection latency
prasad-alatkar opened a new pull request #1000:
URL: https://github.com/apache/mynewt-nimble/pull/1000
## Fix redundant check when extended advertisement flag is enabled.
In `ble_gap.c`, as `params->latency` is of `unsigned uint16_t` type and `BLE_HCI_CONN_LATENCY_MIN` is `0`, the check `(params->latency < BLE_HCI_CONN_LATENCY_MIN)` will always be false and hence can be dropped.
This can give below warnings if custom compiler options are used while compiling the code.
```
warning: comparison is always false due to limited range of data type [-Wtype-limits]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rahult-github commented on pull request #1000: nimble/host: Remove redundant check in connection latency
Posted by GitBox <gi...@apache.org>.
rahult-github commented on pull request #1000:
URL: https://github.com/apache/mynewt-nimble/pull/1000#issuecomment-904592778
Hi @rymanluk , Can you please help merge if there are no further comments ?
> > Looks good. Please just update commit message with the information that params->latency is uint16_t and BLE_HCI_CONN_LATENCY_MIN is 0 which is why we can drop it.
>
> Thanks @rymanluk. Done!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] prasad-alatkar commented on pull request #1000: nimble/host: Remove redundant check in connection latency
Posted by GitBox <gi...@apache.org>.
prasad-alatkar commented on pull request #1000:
URL: https://github.com/apache/mynewt-nimble/pull/1000#issuecomment-886380808
> Looks good. Please just update commit message with the information that params->latency is uint16_t and BLE_HCI_CONN_LATENCY_MIN is 0 which is why we can drop it.
Thanks @rymanluk. Done!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org