You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by georgekankava <gi...@git.apache.org> on 2016/06/21 08:36:13 UTC

[GitHub] accumulo pull request #115: Multiple code improvements - squid:UselessImport...

GitHub user georgekankava opened a pull request:

    https://github.com/apache/accumulo/pull/115

    Multiple code improvements - squid:UselessImportCheck, squid:S2157, squid:S00122, squid:S00116, squid:S1161, squid:S1186

    This pull request is focused on resolving occurrences of Sonar rules
    squid:UselessImportCheck - Useless imports should be removed.
    squid:S2157 - "Cloneables" should implement "clone".
    squid:S00122 - Statements should be on separate lines.
    squid:S00116 - Field names should comply with a naming convention.
    squid:S1161 - "@Override" annotation should be used on any method overriding (since Java 5) or implementing (since Java 6) another one.
    squid:S1186 - Methods should not be empty.
    This pull request removes technical debt of 96 minutes.
    You can find more information about the issue here:
    https://dev.eclipse.org/sonar/rules/show/squid:UselessImportCheck
    https://dev.eclipse.org/sonar/rules/show/squid:S2157
    https://dev.eclipse.org/sonar/rules/show/squid:S00122
    https://dev.eclipse.org/sonar/rules/show/squid:S00116
    https://dev.eclipse.org/sonar/rules/show/squid:S1161
    https://dev.eclipse.org/sonar/rules/show/squid:S1186
    Please let me know if you have any questions.
    George Kankava

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit e0d810531521fc289fba69b405ed8cd1c5b6279e
Author: George Kankava <ge...@devfactory.com>
Date:   2016-06-21T07:58:33Z

    Multiple code improvements - squid:UselessImportCheck, squid:S2157, squid:S00122, squid:S00116, squid:S1161, squid:S1186

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request #115: Multiple code improvements - squid:UselessImport...

Posted by georgekankava <gi...@git.apache.org>.

Github user georgekankava closed the pull request at:

    https://github.com/apache/accumulo/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #115: Multiple code improvements - squid:UselessImportCheck, ...

Posted by georgekankava <gi...@git.apache.org>.

Github user georgekankava commented on the issue:

    https://github.com/apache/accumulo/pull/115
  
    Same comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #115: Multiple code improvements - squid:UselessImportCheck, ...

Posted by dlmarion <gi...@git.apache.org>.

Github user dlmarion commented on the issue:

    https://github.com/apache/accumulo/pull/115
  
    I thought we were leaving the generated code untouched.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo issue #115: Multiple code improvements - squid:UselessImportCheck, ...

Posted by joshelser <gi...@git.apache.org>.

Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/115
  
    You're changing auto-generated code in `core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java`, do not do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---