You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/10/01 06:44:16 UTC
Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3431
https://issues.apache.org/jira/browse/ATLAS-3431
Repository: atlas
Description
-------
A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 0d3d82a11
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java db658639f
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
Diff: https://reviews.apache.org/r/71564/diff/1/
Testing
-------
Added new unit-tests: AtlasEntityStoreV2Test
validated in REST-client
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
Thanks,
Sarath Subramanian
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218012
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Lines 818 (patched)
<https://reviews.apache.org/r/71564/#comment305474>
I think following should be removed from 'if' - to handle the case where an update removes all custom-attributes:
MapUtils.isNotEmpty(entity.getCustomAttributes())
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1175 (patched)
<https://reviews.apache.org/r/71564/#comment305475>
Consider moving validation to earlier phase of entity update, along with rest of attribute validation.
- Madhan Neethiraj
On Oct. 2, 2019, 12:15 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2019, 12:15 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/2/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218041
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 63 (patched)
<https://reviews.apache.org/r/71564/#comment305544>
Is there any impact of increasing the limit once it is set?
- Ashutosh Mestry
On Oct. 2, 2019, 4:51 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2019, 4:51 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/4/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218024
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 2, 2019, 4:51 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2019, 4:51 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/4/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218042
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Oct. 2, 2019, 4:51 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2019, 4:51 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/4/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/
-----------------------------------------------------------
(Updated Oct. 2, 2019, 9:51 a.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3431
https://issues.apache.org/jira/browse/ATLAS-3431
Repository: atlas
Description
-------
A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
Diff: https://reviews.apache.org/r/71564/diff/4/
Changes: https://reviews.apache.org/r/71564/diff/3-4/
Testing
-------
Added new unit-tests: AtlasEntityStoreV2Test
validated in REST-client
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
Thanks,
Sarath Subramanian
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218014
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1170 (patched)
<https://reviews.apache.org/r/71564/#comment305477>
If 'AtlasBaseException' is not thrown from this method, consider removing 'throws' from the signature.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 2195 (patched)
<https://reviews.apache.org/r/71564/#comment305478>
Consider using Pattern.matches(), instead of String.matches():
// line #116
Pattern CUSTOM_ATTRIBUTE_KEY_REGEX = Pattern.compile("^[a-zA-Z0-9_-]*$");
// line #2195
Matcher matcher = CUSTOM_ATTRIBUTE_KEY_REGEX.matcher(key);
if (!matcher.matches(key)) {
throw new AtlasBaseException(AtlasErrorCode.INVALID_CUSTOM_ATTRIBUTE_KEY_CHARACTERS, key);
}
- Madhan Neethiraj
On Oct. 2, 2019, 5:04 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2019, 5:04 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/3/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/
-----------------------------------------------------------
(Updated Oct. 1, 2019, 10:04 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-3431
https://issues.apache.org/jira/browse/ATLAS-3431
Repository: atlas
Description
-------
A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5de2d7c51
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
Diff: https://reviews.apache.org/r/71564/diff/3/
Changes: https://reviews.apache.org/r/71564/diff/2-3/
Testing
-------
Added new unit-tests: AtlasEntityStoreV2Test
validated in REST-client
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
Thanks,
Sarath Subramanian
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/
-----------------------------------------------------------
(Updated Oct. 1, 2019, 5:15 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-3431
https://issues.apache.org/jira/browse/ATLAS-3431
Repository: atlas
Description
-------
A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 607adc059
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 495d7883c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
Diff: https://reviews.apache.org/r/71564/diff/2/
Changes: https://reviews.apache.org/r/71564/diff/1-2/
Testing
-------
Added new unit-tests: AtlasEntityStoreV2Test
validated in REST-client
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
Thanks,
Sarath Subramanian
Re: Review Request 71564: ATLAS-3431: Ability to create and store user
defined key-value pairs in Atlas entity instances
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71564/#review218007
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 158 (patched)
<https://reviews.apache.org/r/71564/#comment305468>
Is it necessary to specify "1 to 50" in this error message? Perhaps there should be 2 messages - one for incorrect contents and another for invalid length?
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java
Lines 64 (patched)
<https://reviews.apache.org/r/71564/#comment305470>
Is customAttributes needed in AtlasEntityHeader?
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 1069 (patched)
<https://reviews.apache.org/r/71564/#comment305471>
Consider initializing 'ret' to 'null' here.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Lines 822 (patched)
<https://reviews.apache.org/r/71564/#comment305472>
Consider using Objects.equals() - to handle null values.
- Madhan Neethiraj
On Oct. 1, 2019, 6:44 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71564/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2019, 6:44 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3431
> https://issues.apache.org/jira/browse/ATLAS-3431
>
>
> Repository: atlas
>
>
> Description
> -------
>
> A data steward would like to be able to store arbitrary key-value pair data on any entity in Atlas so they can enrich and annotate instances with additional context.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 67493baab
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 981cfc7d8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3cc91a586
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 0d3d82a11
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java db658639f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java c921130f6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java a4edaf086
>
>
> Diff: https://reviews.apache.org/r/71564/diff/1/
>
>
> Testing
> -------
>
> Added new unit-tests: AtlasEntityStoreV2Test
>
> validated in REST-client
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/
>
>
> Thanks,
>
> Sarath Subramanian
>
>