You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/03 21:12:47 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2858:
[GOBBLIN-1014] Fix error handling in gobblin.sh
codecov-io commented on issue #2858: [GOBBLIN-1014] Fix error handling in gobblin.sh
URL: https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-570699740
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=h1) Report
> Merging [#2858](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2858 +/- ##
============================================
+ Coverage 45.72% 45.75% +0.03%
- Complexity 9085 9105 +20
============================================
Files 1913 1917 +4
Lines 72021 72131 +110
Branches 7943 7956 +13
============================================
+ Hits 32929 33006 +77
- Misses 36074 36100 +26
- Partials 3018 3025 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `77.04% <0%> (ø)` | `11% <0%> (?)` | |
| [...ion/suite/CompactionWithWatermarkSuiteFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZUZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [.../compaction/verify/CompactionWatermarkChecker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25XYXRlcm1hcmtDaGVja2VyLmphdmE=) | `92.85% <0%> (ø)` | `9% <0%> (?)` | |
| [...compaction/suite/CompactionWithWatermarkSuite.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...ta/management/dataset/TimePartitionGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvVGltZVBhcnRpdGlvbkdsb2JGaW5kZXIuamF2YQ==) | `93.61% <0%> (+0.21%)` | `24% <0%> (+1%)` | :arrow_up: |
| [...gobblin/compaction/mapreduce/MRCompactionTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdGlvblRhc2suamF2YQ==) | `76.19% <0%> (+0.58%)` | `9% <0%> (ø)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=footer). Last update [4483268...26caf4c](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services