[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

["Lars Hofhansl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966389#comment-16966389 ] 

Lars Hofhansl commented on PHOENIX-3547:
----------------------------------------

Please see: PHOENIX-5104, PHOENIX-5559, PHOENIX-5550, PHOENIX-5486.

If those are not fixed in a reasonable timeframe I'm going to -1 this change and revert this and all followup changes. Sorry for being the party pooper, but the the problems from this just seem to mushroom out. And I won't have to look at this more (already spending my weekend time on this.) :(

We really have not thought the backwards compatibility story through, nor is the code tested enough with both long and short viewIndexIds - or we would not have found so many issues with this. One way to test this is to change the behavior of the 4.15.0 client to behave exactly like the 4.14. client when phoenix.index.longViewIndex.enabled is set to false and then run some tests that way.

I know this is cool feature. Then again, as is Phoenix is unreleasable, the release train is coming by now, and this feature is not ready, so it needs be ready or get off the train and be reconsidered for 4.15.1 (if that's possible) or for 4.16.0.

[~m2je], [~rajeshbabu], [~gjacoby].

 

> Promote CATALOG.VIEW_INDEX_ID to an int
> ---------------------------------------
>
>                 Key: PHOENIX-3547
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3547
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Jeremy Huffman
>            Assignee: Mehdi Salarkia
>            Priority: Minor
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: 4.x-HBase-0.98.patch, 4.x-HBase-1.1.patch, 4.x-HBase-1.2.patch, 4.x-HBase-1.3.patch, 4.x-HBase-1.4.patch, 4.x-cdh5.11.patch, 4.x-cdh5.12.patch, 4.x-cdh5.13.patch, 4.x-cdh5.14.patch, master-PHOENIX-3547.patch
>
>
> Increase the size of CATALOG.VIEW_INDEX_ID from smallint to int to support a large number of indexed views on a single table.
> Per James: "The code would just need to be tolerant when reading the data if the length is two byte short versus four byte int. At write time, we'd just always write an int."
> See: https://lists.apache.org/thread.html/22849e4fc73452cee3bea763cf6d5af7164dedcb44573ba6b9f452a2@%3Cuser.phoenix.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)