You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/10 00:09:29 UTC

[GitHub] [airflow] gdevanla commented on issue #8696: Skip task itself instead of all downstream tasks

gdevanla commented on issue #8696:
URL: https://github.com/apache/airflow/issues/8696#issuecomment-626252453


   @yuqian90 I believe you are pointing to this line of code which should not be performing this task here.  
   
   https://github.com/apache/airflow/blob/7506c73f1721151e9c50ef8bdb70d2136a16190b/airflow/sensors/base_sensor_operator.py#L121
   
   As I understand it, when the jobs are not skipped here, the current set up in TriggerRuleDep._evaluate_trigger_rule() takes care of skipping the tasks for appropriate conditions.
   
   https://github.com/apache/airflow/blob/7506c73f1721151e9c50ef8bdb70d2136a16190b/airflow/ti_deps/deps/trigger_rule_dep.py#L128
   
   Any thoughts on this change along these lines?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org