You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/14 13:14:35 UTC
[GitHub] [shardingsphere] qhj348770376 opened a new issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
qhj348770376 opened a new issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611
how do you guys improve performance of parsing SQL at first time in the version 4.1.0?by upgrading the version of antlr4 to 4.7.2?
@tuohai666 #2793 #5313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 edited a comment on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 edited a comment on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629054194
> > Have you done performance testing? How much performance has been improved?
>
> Yes. About 100 ~ 1000 times faster for long SQL.
>
> How do you judge the slow part is parse? And what the SQL it is?
SQL:select * from group_strategy where id=?
first time cost 1210ms and second time 4ms
our qps is 1000
@tuohai666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629046119
> We use two phase parse(LL and SLL) to improve performance.
Have you done performance testing? How much performance has been improved? Our production environment test is still very slow to parse SQL for the first time at version 4.1.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-634381961
> You didn't answer my question: **How do you judge the slow part is parse?**
>
> You are using a sharding-proxy or sharding-jdbc?

1、As can be seen from the screenshot, most of the performance loss is in SQL parsing
2、sharding-jdbc 4.1.0
From the list of historical issues, it can be found that the service timeout or slow response caused by the first analysis of SQL performance problems is a very clear problem. Other companies have the same problem. I think the official should not avoid this problem. It should be taken seriously. Help us solve this problem.
If there are thousands of service QPS and hundreds of different SQL statements are parsed at the same time, this problem can be reproduced stably. And the official cache solution does not solve this kind of problem, the cache can only improve the resolution performance for the second time and later,not the first time . #2793 #5313
please!!!
@terrymanu @tuohai666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-634409519
OK,I let the business department sort out the relevant debugging information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 closed issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 closed issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-632490619
Expired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 closed issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 closed issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629063580
You didn't answer my question: **How do you judge the slow part is parse?**
You are using a sharding-proxy or sharding-jdbc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629052104
> Have you done performance testing? How much performance has been improved?
Yes. About 100 ~ 1000 times faster for long SQL.
How do you judge the slow part is parse? And what the SQL it is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 edited a comment on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 edited a comment on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629046119
> We use two phase parse(LL and SLL) to improve performance.
Have you done performance testing? How much performance has been improved? Our production environment test is still very slow to parse SQL for the first time at version 4.1.0 @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] qhj348770376 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
qhj348770376 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629054194
> > Have you done performance testing? How much performance has been improved?
>
> Yes. About 100 ~ 1000 times faster for long SQL.
>
> How do you judge the slow part is parse? And what the SQL it is?
SQL:select * from group_strategy where id=?
first time cost 1210ms and second time 4ms
@tuohai666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-634395393
I thought you would provide the 1210ms log. Why 39ms this time?
Please show me the trace from the entry of your code.
What's the hardware environment of your machine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #5611: how do you guys improve performance of parsing SQL at first time in the version 4.1.0 ?by upgrading the version of antlr4 to 4.7.2?
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #5611:
URL: https://github.com/apache/shardingsphere/issues/5611#issuecomment-629006277
We use two phase parse(LL and SLL) to improve performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org