You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by cpoerschke <gi...@git.apache.org> on 2015/06/30 21:10:55 UTC
[GitHub] lucene-solr pull request: [incomplete] SOLR-5730: make SortingMerg...
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/176
[incomplete] SOLR-5730: make SortingMergePolicy/EarlyTerminatingSortingCollector configurable
incomplete. for https://issues.apache.org/jira/i#browse/SOLR-5730 ticket.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-sort-outline
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 5984692c660b32ddec0260e5a096b7b7eea5ea8d
Author: Christine Poerschke <cp...@bloomberg.net>
Date: 2015-06-29T15:02:44Z
LUCENE-????: support SortingMergePolicy-free use of EarlyTerminatingSortingCollector
motivation:
* SOLR-5730 to make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr.
* outline of draft SOLR-5730 changes:
+ SolrIndexWriter constructor calls SolrIndexConfig.toIndexWriterConfig (passing the result to its lucene.IndexWriter super class)
+ SolrIndexConfig.toIndexWriterConfig(SolrCore core) calls SolrIndexConfig.buildMergePolicy
+ SolrIndexConfig.buildMergePolicy(IndexSchema schema) calls the SortingMergePolicy constructor (using the IndexSchema's mergeSortSpec)
+ SolrIndexSearcher.buildAndRunCollectorChain calls the EarlyTerminatingSortingCollector constructor (using the IndexSchema's mergeSortSpec)
summary of changes:
* added static isSorted variant to SortingMergePolicy
* added SortingMergePolicy-free EarlyTerminatingSortingCollector constructor variant
* added SortingMergePolicy-free EarlyTerminatingSortingCollector.canEarlyTerminate variant
* corresponding changes to TestEarlyTerminatingSortingCollector (randomly choose between constructor and canEarlyTerminate variants)
commit 78de6620a9f50ab632c1fc240a336137acf9199f
Author: Christine Poerschke <cp...@bloomberg.net>
Date: 2015-06-29T14:22:29Z
[incomplete] SOLR-5730: make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr
summary of changes so far:
* schema.xml: added optional mergeSortSpec field to [Managed]IndexSchema
* solrconfig.xml: SolrIndexConfig.buildMergePolicy to constructs a SortingMergePolicy if the useSortingMergePolicy flag is set
* optional segmentTerminateEarly parameter added to CommonParams and QueryComponent (defaulted to existing behaviour)
* SolrIndexSearcher: constructs EarlyTerminatingSortingCollector if segmentTerminateEarly flag is set (and requested sort is compatible with the mergeSortSpec)
still incomplete:
* IndexSchema: convert/parse 'String mergeSortSpecString;' into 'SortSpec mergeSortSpec;'
* queryResult caching to consider the segmentTerminateEarly flag (a segmentTerminateEarly=false search should not get cached results from a segmentTerminateEarly=true search)
* documentation/example for the segmentTerminateEarly query parameter (and the new optional schema.xml/solrconfig.xml elements)
* test cases
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #176: SOLR-10263 : Override spellcheck's SuggestMode by Wo...
Posted by abhidemon <gi...@git.apache.org>.
Github user abhidemon commented on the issue:
https://github.com/apache/lucene-solr/pull/176
For this Issue. https://issues.apache.org/jira/browse/SOLR-10263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org