You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/01/25 07:01:37 UTC

[PR] [SPARK-46855][INFRA] Add `sketch` to the dependencies of the `catalyst` module in `module.py` [spark]

LuciferYang opened a new pull request, #44878:
URL: https://github.com/apache/spark/pull/44878

   ### What changes were proposed in this pull request?
   This pr add `sketch` to the dependencies of the `catalyst` module in `module.py` due to `sketch` is direct dependency of `catalyst` module.
   
   ### Why are the changes needed?
   Ensure that when modifying the `sketch` module, both `catalyst` and cascading modules will trigger tests.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46855][INFRA] Add `sketch` to the dependencies of the `catalyst` in `module.py` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44878:
URL: https://github.com/apache/spark/pull/44878#issuecomment-1910559329

   Thank you for fixing this, @LuciferYang .
   
   I merged this to `master` only because I respect your decision which filed SPARK-46855 as an Improvement. However, this was caused by SPARK-18429 at Spark 2.2, feel free to make a backport if you want.
   
   ![Screenshot 2024-01-25 at 8 28 00 AM](https://github.com/apache/spark/assets/9700541/afd52768-dc69-4563-98d3-e2df4bba6f18)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46855][INFRA] Add `sketch` to the dependencies of the `catalyst` in `module.py` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44878: [SPARK-46855][INFRA] Add `sketch` to the dependencies of the `catalyst` in `module.py`
URL: https://github.com/apache/spark/pull/44878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46855][INFRA] Add `sketch` to the dependencies of the `catalyst` in `module.py` [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44878:
URL: https://github.com/apache/spark/pull/44878#issuecomment-1911501754

   Thanks @dongjoon-hyun @zhengruifeng 
   
   @dongjoon-hyun I have changed the `type` of SPARK-46855 from `Improvement` to `bug`, and backported it to branch-3.5 and branch-3.4:
   - branch-3.5: https://github.com/apache/spark/pull/44893
   - branch-3.4: https://github.com/apache/spark/pull/44894


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org