You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Greg Dove <gr...@gmail.com> on 2019/03/01 05:27:52 UTC
quick check on branches
Hi Alex - or anyone else who knows - for setting up a compilable branch, am
I supposed to commit to the same branch name in all three of : as-js,
typedefs and compiler ? I have only changes in asjs and compiler. But I can
create a same name branch in typedefs as well if that is required....
Thanks,
Greg
Re: quick check on branches
Posted by Carlos Rovira <ca...@apache.org>.
Hi,
I saw something that could be a problems is we didn't have:
import org.apache.royale.reflection.registerClassAlias;
import mx.messaging.messages.AcknowledgeMessageExt;
import mx.messaging.messages.AsyncMessageExt;
import mx.messaging.messages.CommandMessageExt;
//RpcClassAliasInitializer
registerClassAlias("DSK", AcknowledgeMessageExt);
registerClassAlias("DSA", AsyncMessageExt);
registerClassAlias("DSC", CommandMessageExt);
so I added and removed similar ones from Network since I never get that
working, and committed to the amp_updates branch
small messages still doesn't work but I think that should be a piece of the
puzzle, maybe @greg that knows the internals of the refactor could know
what is missing, maybe is something that is still not in our implementation.
btw, for me is ok to merge this branch and we can finish small messages
with all this integrated.
thanks
Carlos
El mié., 6 mar. 2019 a las 12:36, Carlos Rovira (<ca...@apache.org>)
escribió:
> One more thing, I'm seeing this in my console:
>
> TypeError: Cannot read property 'DSId' of undefined
> AMFChannel.js:260
> at QV.L.faultHandler (
> /Users/carlosrovira/Dev/Codeoscopic/Source/sgc/webapp/src/main/webapp/javascript/bin/js-debug/mx/messaging/channels/AMFChannel.js:260:65
> )
> at XMLHttpRequest.<anonymous> (
> /Users/carlosrovira/Dev/Codeoscopic/Source/sgc/webapp/src/main/webapp/javascript/bin/js-debug/org/apache/royale/net/remoting/amf/AMFNetConnection.js:293:7
> )
>
> El mié., 6 mar. 2019 a las 12:29, Carlos Rovira (<ca...@apache.org>)
> escribió:
>
>> Hi
>>
>> set enable-small-messages to true in services-config.xml but didn't
>> work. I Think there should be something still missing.
>>
>> I see with have in our ServicesConfig.mxml royale class that I need to
>> change
>>
>> channelSet.useSmallMessages
>>
>> from false to true
>>
>> but didn't see other points where I should do other configuration
>> updates. Maybe there could be others
>>
>>
>> I see as well in MXRoyale we have classes like AcknowledgeMessageExt or CommandMessageExt
>> in place, so
>> if when migration of RPC package was done there was no other changes
>> that could affect this, don't know what could be the problem.
>>
>>
>> El mié., 6 mar. 2019 a las 11:40, Carlos Rovira (<ca...@apache.org>)
>> escribió:
>>
>>> Hi Greg,
>>>
>>> I finally could test AMF branch. I merged locally latest changes in
>>> compiler and asjs frameworks, to ensure to be to the latest. As well in our
>>> real project I tried all workflows and all worked great!
>>> So congrats for this great updates! :)
>>>
>>> I'm going now to stop server and try to turn on small messages in
>>> BlazeDS to see what happens
>>>
>>> report here as I get results
>>>
>>>
>>>
>>> El vie., 1 mar. 2019 a las 9:26, Carlos Rovira (<ca...@apache.org>)
>>> escribió:
>>>
>>>> Hi Greg,
>>>>
>>>> Wow! Browsing the branch and must say. Amazing work! :)
>>>>
>>>> For small-messages I think one way to try it would be test against our
>>>> real app turning them on and see what happens. Having now IExternalizable
>>>> working should be enough for RPC using the three messages that use that (I
>>>> think there's no more), and I think those classes are available and listed
>>>> in the swc since many months.
>>>>
>>>> Since this week-end I'm on trip, I'll be able to join to this testing
>>>> on my Monday evening.
>>>>
>>>> I think this improvements will be very important for all of us and
>>>> including people coming to migrate from flex, like other the ones that come
>>>> some months ago with ColdFusion or AMFPHP backends that couldn't get AMF
>>>> work, having this so close to flash/flex should help those people to
>>>> finally get it work.
>>>>
>>>> Carlos
>>>>
>>>>
>>>>
>>>> El vie., 1 mar. 2019 a las 7:23, Greg Dove (<gr...@gmail.com>)
>>>> escribió:
>>>>
>>>>> Ok, thanks Alex. I will not do that then. I did not prefix the names
>>>>> with
>>>>> 'feature' anyway...
>>>>> I will push to 'amf_updates' branch for compiler and asjs inside the
>>>>> next
>>>>> couple of hours. I have more to do on this work, but it's moving
>>>>> forward -
>>>>> dynamic and IExternalizable are now supported, although I have not
>>>>> tested
>>>>> the short messaging stuff yet.
>>>>> I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and
>>>>> that is
>>>>> working.
>>>>>
>>>>> But there will be some things to discuss (will follow up on list
>>>>> tomorrow)
>>>>> and I still have a few more things queued up to work on with
>>>>> AMFBinaryData
>>>>> (IDynamicPropertyWriter, XML, Vectors - I did not test/check these
>>>>> yet, and
>>>>> perhaps something for Dictionary)
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid>
>>>>> wrote:
>>>>>
>>>>> > I haven't checked on the Maven Pipeline to see if it is operational
>>>>> or
>>>>> > not. IIRC, it was the only thing that required all 3 branches to
>>>>> have the
>>>>> > same name, and I think it had to start with feature/ or release/.
>>>>> For the
>>>>> > rest of us, it doesn't matter. You checkout the branch you want and
>>>>> build
>>>>> > it and it will end up being the code that is used.
>>>>> >
>>>>> > HTH,
>>>>> > -Alex
>>>>> >
>>>>> > On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>>>>> >
>>>>> > Hi Alex - or anyone else who knows - for setting up a compilable
>>>>> > branch, am
>>>>> > I supposed to commit to the same branch name in all three of :
>>>>> as-js,
>>>>> > typedefs and compiler ? I have only changes in asjs and
>>>>> compiler. But
>>>>> > I can
>>>>> > create a same name branch in typedefs as well if that is
>>>>> required....
>>>>> >
>>>>> > Thanks,
>>>>> > Greg
>>>>> >
>>>>> >
>>>>> >
>>>>>
>>>>
>>>>
>>>> --
>>>> Carlos Rovira
>>>> http://about.me/carlosrovira
>>>>
>>>>
>>>
>>> --
>>> Carlos Rovira
>>> http://about.me/carlosrovira
>>>
>>>
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: quick check on branches
Posted by Carlos Rovira <ca...@apache.org>.
One more thing, I'm seeing this in my console:
TypeError: Cannot read property 'DSId' of undefined
AMFChannel.js:260
at QV.L.faultHandler (
/Users/carlosrovira/Dev/Codeoscopic/Source/sgc/webapp/src/main/webapp/javascript/bin/js-debug/mx/messaging/channels/AMFChannel.js:260:65
)
at XMLHttpRequest.<anonymous> (
/Users/carlosrovira/Dev/Codeoscopic/Source/sgc/webapp/src/main/webapp/javascript/bin/js-debug/org/apache/royale/net/remoting/amf/AMFNetConnection.js:293:7
)
El mié., 6 mar. 2019 a las 12:29, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi
>
> set enable-small-messages to true in services-config.xml but didn't work.
> I Think there should be something still missing.
>
> I see with have in our ServicesConfig.mxml royale class that I need to
> change
>
> channelSet.useSmallMessages
>
> from false to true
>
> but didn't see other points where I should do other configuration
> updates. Maybe there could be others
>
>
> I see as well in MXRoyale we have classes like AcknowledgeMessageExt or CommandMessageExt
> in place, so
> if when migration of RPC package was done there was no other changes that
> could affect this, don't know what could be the problem.
>
>
> El mié., 6 mar. 2019 a las 11:40, Carlos Rovira (<ca...@apache.org>)
> escribió:
>
>> Hi Greg,
>>
>> I finally could test AMF branch. I merged locally latest changes in
>> compiler and asjs frameworks, to ensure to be to the latest. As well in our
>> real project I tried all workflows and all worked great!
>> So congrats for this great updates! :)
>>
>> I'm going now to stop server and try to turn on small messages in BlazeDS
>> to see what happens
>>
>> report here as I get results
>>
>>
>>
>> El vie., 1 mar. 2019 a las 9:26, Carlos Rovira (<ca...@apache.org>)
>> escribió:
>>
>>> Hi Greg,
>>>
>>> Wow! Browsing the branch and must say. Amazing work! :)
>>>
>>> For small-messages I think one way to try it would be test against our
>>> real app turning them on and see what happens. Having now IExternalizable
>>> working should be enough for RPC using the three messages that use that (I
>>> think there's no more), and I think those classes are available and listed
>>> in the swc since many months.
>>>
>>> Since this week-end I'm on trip, I'll be able to join to this testing on
>>> my Monday evening.
>>>
>>> I think this improvements will be very important for all of us and
>>> including people coming to migrate from flex, like other the ones that come
>>> some months ago with ColdFusion or AMFPHP backends that couldn't get AMF
>>> work, having this so close to flash/flex should help those people to
>>> finally get it work.
>>>
>>> Carlos
>>>
>>>
>>>
>>> El vie., 1 mar. 2019 a las 7:23, Greg Dove (<gr...@gmail.com>)
>>> escribió:
>>>
>>>> Ok, thanks Alex. I will not do that then. I did not prefix the names
>>>> with
>>>> 'feature' anyway...
>>>> I will push to 'amf_updates' branch for compiler and asjs inside the
>>>> next
>>>> couple of hours. I have more to do on this work, but it's moving
>>>> forward -
>>>> dynamic and IExternalizable are now supported, although I have not
>>>> tested
>>>> the short messaging stuff yet.
>>>> I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and
>>>> that is
>>>> working.
>>>>
>>>> But there will be some things to discuss (will follow up on list
>>>> tomorrow)
>>>> and I still have a few more things queued up to work on with
>>>> AMFBinaryData
>>>> (IDynamicPropertyWriter, XML, Vectors - I did not test/check these yet,
>>>> and
>>>> perhaps something for Dictionary)
>>>>
>>>>
>>>>
>>>>
>>>> On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid>
>>>> wrote:
>>>>
>>>> > I haven't checked on the Maven Pipeline to see if it is operational or
>>>> > not. IIRC, it was the only thing that required all 3 branches to
>>>> have the
>>>> > same name, and I think it had to start with feature/ or release/.
>>>> For the
>>>> > rest of us, it doesn't matter. You checkout the branch you want and
>>>> build
>>>> > it and it will end up being the code that is used.
>>>> >
>>>> > HTH,
>>>> > -Alex
>>>> >
>>>> > On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>>>> >
>>>> > Hi Alex - or anyone else who knows - for setting up a compilable
>>>> > branch, am
>>>> > I supposed to commit to the same branch name in all three of :
>>>> as-js,
>>>> > typedefs and compiler ? I have only changes in asjs and compiler.
>>>> But
>>>> > I can
>>>> > create a same name branch in typedefs as well if that is
>>>> required....
>>>> >
>>>> > Thanks,
>>>> > Greg
>>>> >
>>>> >
>>>> >
>>>>
>>>
>>>
>>> --
>>> Carlos Rovira
>>> http://about.me/carlosrovira
>>>
>>>
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: quick check on branches
Posted by Carlos Rovira <ca...@apache.org>.
Hi
set enable-small-messages to true in services-config.xml but didn't work. I
Think there should be something still missing.
I see with have in our ServicesConfig.mxml royale class that I need to
change
channelSet.useSmallMessages
from false to true
but didn't see other points where I should do other configuration updates.
Maybe there could be others
I see as well in MXRoyale we have classes like AcknowledgeMessageExt
or CommandMessageExt
in place, so
if when migration of RPC package was done there was no other changes that
could affect this, don't know what could be the problem.
El mié., 6 mar. 2019 a las 11:40, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Greg,
>
> I finally could test AMF branch. I merged locally latest changes in
> compiler and asjs frameworks, to ensure to be to the latest. As well in our
> real project I tried all workflows and all worked great!
> So congrats for this great updates! :)
>
> I'm going now to stop server and try to turn on small messages in BlazeDS
> to see what happens
>
> report here as I get results
>
>
>
> El vie., 1 mar. 2019 a las 9:26, Carlos Rovira (<ca...@apache.org>)
> escribió:
>
>> Hi Greg,
>>
>> Wow! Browsing the branch and must say. Amazing work! :)
>>
>> For small-messages I think one way to try it would be test against our
>> real app turning them on and see what happens. Having now IExternalizable
>> working should be enough for RPC using the three messages that use that (I
>> think there's no more), and I think those classes are available and listed
>> in the swc since many months.
>>
>> Since this week-end I'm on trip, I'll be able to join to this testing on
>> my Monday evening.
>>
>> I think this improvements will be very important for all of us and
>> including people coming to migrate from flex, like other the ones that come
>> some months ago with ColdFusion or AMFPHP backends that couldn't get AMF
>> work, having this so close to flash/flex should help those people to
>> finally get it work.
>>
>> Carlos
>>
>>
>>
>> El vie., 1 mar. 2019 a las 7:23, Greg Dove (<gr...@gmail.com>)
>> escribió:
>>
>>> Ok, thanks Alex. I will not do that then. I did not prefix the names with
>>> 'feature' anyway...
>>> I will push to 'amf_updates' branch for compiler and asjs inside the next
>>> couple of hours. I have more to do on this work, but it's moving forward
>>> -
>>> dynamic and IExternalizable are now supported, although I have not tested
>>> the short messaging stuff yet.
>>> I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and that
>>> is
>>> working.
>>>
>>> But there will be some things to discuss (will follow up on list
>>> tomorrow)
>>> and I still have a few more things queued up to work on with
>>> AMFBinaryData
>>> (IDynamicPropertyWriter, XML, Vectors - I did not test/check these yet,
>>> and
>>> perhaps something for Dictionary)
>>>
>>>
>>>
>>>
>>> On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid>
>>> wrote:
>>>
>>> > I haven't checked on the Maven Pipeline to see if it is operational or
>>> > not. IIRC, it was the only thing that required all 3 branches to have
>>> the
>>> > same name, and I think it had to start with feature/ or release/. For
>>> the
>>> > rest of us, it doesn't matter. You checkout the branch you want and
>>> build
>>> > it and it will end up being the code that is used.
>>> >
>>> > HTH,
>>> > -Alex
>>> >
>>> > On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>>> >
>>> > Hi Alex - or anyone else who knows - for setting up a compilable
>>> > branch, am
>>> > I supposed to commit to the same branch name in all three of :
>>> as-js,
>>> > typedefs and compiler ? I have only changes in asjs and compiler.
>>> But
>>> > I can
>>> > create a same name branch in typedefs as well if that is
>>> required....
>>> >
>>> > Thanks,
>>> > Greg
>>> >
>>> >
>>> >
>>>
>>
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: quick check on branches
Posted by Carlos Rovira <ca...@apache.org>.
Hi Greg,
I finally could test AMF branch. I merged locally latest changes in
compiler and asjs frameworks, to ensure to be to the latest. As well in our
real project I tried all workflows and all worked great!
So congrats for this great updates! :)
I'm going now to stop server and try to turn on small messages in BlazeDS
to see what happens
report here as I get results
El vie., 1 mar. 2019 a las 9:26, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Greg,
>
> Wow! Browsing the branch and must say. Amazing work! :)
>
> For small-messages I think one way to try it would be test against our
> real app turning them on and see what happens. Having now IExternalizable
> working should be enough for RPC using the three messages that use that (I
> think there's no more), and I think those classes are available and listed
> in the swc since many months.
>
> Since this week-end I'm on trip, I'll be able to join to this testing on
> my Monday evening.
>
> I think this improvements will be very important for all of us and
> including people coming to migrate from flex, like other the ones that come
> some months ago with ColdFusion or AMFPHP backends that couldn't get AMF
> work, having this so close to flash/flex should help those people to
> finally get it work.
>
> Carlos
>
>
>
> El vie., 1 mar. 2019 a las 7:23, Greg Dove (<gr...@gmail.com>)
> escribió:
>
>> Ok, thanks Alex. I will not do that then. I did not prefix the names with
>> 'feature' anyway...
>> I will push to 'amf_updates' branch for compiler and asjs inside the next
>> couple of hours. I have more to do on this work, but it's moving forward -
>> dynamic and IExternalizable are now supported, although I have not tested
>> the short messaging stuff yet.
>> I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and that
>> is
>> working.
>>
>> But there will be some things to discuss (will follow up on list tomorrow)
>> and I still have a few more things queued up to work on with AMFBinaryData
>> (IDynamicPropertyWriter, XML, Vectors - I did not test/check these yet,
>> and
>> perhaps something for Dictionary)
>>
>>
>>
>>
>> On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid>
>> wrote:
>>
>> > I haven't checked on the Maven Pipeline to see if it is operational or
>> > not. IIRC, it was the only thing that required all 3 branches to have
>> the
>> > same name, and I think it had to start with feature/ or release/. For
>> the
>> > rest of us, it doesn't matter. You checkout the branch you want and
>> build
>> > it and it will end up being the code that is used.
>> >
>> > HTH,
>> > -Alex
>> >
>> > On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>> >
>> > Hi Alex - or anyone else who knows - for setting up a compilable
>> > branch, am
>> > I supposed to commit to the same branch name in all three of :
>> as-js,
>> > typedefs and compiler ? I have only changes in asjs and compiler.
>> But
>> > I can
>> > create a same name branch in typedefs as well if that is
>> required....
>> >
>> > Thanks,
>> > Greg
>> >
>> >
>> >
>>
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: quick check on branches
Posted by Carlos Rovira <ca...@apache.org>.
Hi Greg,
Wow! Browsing the branch and must say. Amazing work! :)
For small-messages I think one way to try it would be test against our real
app turning them on and see what happens. Having now IExternalizable
working should be enough for RPC using the three messages that use that (I
think there's no more), and I think those classes are available and listed
in the swc since many months.
Since this week-end I'm on trip, I'll be able to join to this testing on my
Monday evening.
I think this improvements will be very important for all of us and
including people coming to migrate from flex, like other the ones that come
some months ago with ColdFusion or AMFPHP backends that couldn't get AMF
work, having this so close to flash/flex should help those people to
finally get it work.
Carlos
El vie., 1 mar. 2019 a las 7:23, Greg Dove (<gr...@gmail.com>) escribió:
> Ok, thanks Alex. I will not do that then. I did not prefix the names with
> 'feature' anyway...
> I will push to 'amf_updates' branch for compiler and asjs inside the next
> couple of hours. I have more to do on this work, but it's moving forward -
> dynamic and IExternalizable are now supported, although I have not tested
> the short messaging stuff yet.
> I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and that is
> working.
>
> But there will be some things to discuss (will follow up on list tomorrow)
> and I still have a few more things queued up to work on with AMFBinaryData
> (IDynamicPropertyWriter, XML, Vectors - I did not test/check these yet, and
> perhaps something for Dictionary)
>
>
>
>
> On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid>
> wrote:
>
> > I haven't checked on the Maven Pipeline to see if it is operational or
> > not. IIRC, it was the only thing that required all 3 branches to have
> the
> > same name, and I think it had to start with feature/ or release/. For
> the
> > rest of us, it doesn't matter. You checkout the branch you want and
> build
> > it and it will end up being the code that is used.
> >
> > HTH,
> > -Alex
> >
> > On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
> >
> > Hi Alex - or anyone else who knows - for setting up a compilable
> > branch, am
> > I supposed to commit to the same branch name in all three of : as-js,
> > typedefs and compiler ? I have only changes in asjs and compiler. But
> > I can
> > create a same name branch in typedefs as well if that is required....
> >
> > Thanks,
> > Greg
> >
> >
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: quick check on branches
Posted by Greg Dove <gr...@gmail.com>.
Ok, thanks Alex. I will not do that then. I did not prefix the names with
'feature' anyway...
I will push to 'amf_updates' branch for compiler and asjs inside the next
couple of hours. I have more to do on this work, but it's moving forward -
dynamic and IExternalizable are now supported, although I have not tested
the short messaging stuff yet.
I updated mxroyale\RemoteObjectAMFTest to use mxArrayCollection and that is
working.
But there will be some things to discuss (will follow up on list tomorrow)
and I still have a few more things queued up to work on with AMFBinaryData
(IDynamicPropertyWriter, XML, Vectors - I did not test/check these yet, and
perhaps something for Dictionary)
On Fri, Mar 1, 2019 at 6:56 PM Alex Harui <ah...@adobe.com.invalid> wrote:
> I haven't checked on the Maven Pipeline to see if it is operational or
> not. IIRC, it was the only thing that required all 3 branches to have the
> same name, and I think it had to start with feature/ or release/. For the
> rest of us, it doesn't matter. You checkout the branch you want and build
> it and it will end up being the code that is used.
>
> HTH,
> -Alex
>
> On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>
> Hi Alex - or anyone else who knows - for setting up a compilable
> branch, am
> I supposed to commit to the same branch name in all three of : as-js,
> typedefs and compiler ? I have only changes in asjs and compiler. But
> I can
> create a same name branch in typedefs as well if that is required....
>
> Thanks,
> Greg
>
>
>
Re: quick check on branches
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Greg,
Yep that was the case. A while ago I was quite often looking into that but
stopped. I'm wondering whether that triggers for pipe line even work. I
don't remember even addresses. :(
Thanks,
Piotr
On Fri, Mar 1, 2019, 6:56 AM Alex Harui <ah...@adobe.com.invalid> wrote:
> I haven't checked on the Maven Pipeline to see if it is operational or
> not. IIRC, it was the only thing that required all 3 branches to have the
> same name, and I think it had to start with feature/ or release/. For the
> rest of us, it doesn't matter. You checkout the branch you want and build
> it and it will end up being the code that is used.
>
> HTH,
> -Alex
>
> On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
>
> Hi Alex - or anyone else who knows - for setting up a compilable
> branch, am
> I supposed to commit to the same branch name in all three of : as-js,
> typedefs and compiler ? I have only changes in asjs and compiler. But
> I can
> create a same name branch in typedefs as well if that is required....
>
> Thanks,
> Greg
>
>
>
Re: quick check on branches
Posted by Alex Harui <ah...@adobe.com.INVALID>.
I haven't checked on the Maven Pipeline to see if it is operational or not. IIRC, it was the only thing that required all 3 branches to have the same name, and I think it had to start with feature/ or release/. For the rest of us, it doesn't matter. You checkout the branch you want and build it and it will end up being the code that is used.
HTH,
-Alex
On 2/28/19, 9:34 PM, "Greg Dove" <gr...@gmail.com> wrote:
Hi Alex - or anyone else who knows - for setting up a compilable branch, am
I supposed to commit to the same branch name in all three of : as-js,
typedefs and compiler ? I have only changes in asjs and compiler. But I can
create a same name branch in typedefs as well if that is required....
Thanks,
Greg