You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2018/03/27 09:36:00 UTC
[jira] [Comment Edited] (SOLR-10734) Multithreaded test/support for
AtomicURP broken
[ https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415319#comment-16415319 ]
Shalin Shekhar Mangar edited comment on SOLR-10734 at 3/27/18 9:35 AM:
-----------------------------------------------------------------------
This patch fixes the test failures. The problem was that the assert in question tried to query for multiple terms on the "cat" field but the terms were not inside a parenthesis. So only the first term was queried against the "cat" field and the rest were queried against the default search field. Sometimes, the random term selection for the atomic updates would skip the first term entirely and then the query would not match any docs thereby failing the assert.
Edit -- I see that Amrit had already spotted the problem and provided a fix. Serves me right for not reading all the comments in this issue before debugging :)
was (Author: shalinmangar):
This patch fixes the test failures. The problem was that the assert in question tried to query for multiple terms on the "cat" field but the terms were not inside a parenthesis. So only the first term was queried against the "cat" field and the rest were queried against the default search field. Sometimes, the random term selection for the atomic updates would skip the first term entirely and then the query would not match any docs thereby failing the assert.
> Multithreaded test/support for AtomicURP broken
> -----------------------------------------------
>
> Key: SOLR-10734
> URL: https://issues.apache.org/jira/browse/SOLR-10734
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Assignee: Shalin Shekhar Mangar
> Priority: Major
> Fix For: 7.3, master (8.0)
>
> Attachments: SOLR-10734.patch, SOLR-10734.patch, SOLR-10734.patch, SOLR-10734.patch, Screen Shot 2017-05-31 at 4.50.23 PM.png, log-snippet, testMaster_2500, testResults7_10, testResultsMaster_10
>
>
> The multithreaded test doesn't actually start the threads, but only invokes the run directly. The join afterwards doesn't do anything, hence.
> {code}
> diff --git a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> index f3f833d..10b7770 100644
> --- a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> +++ b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends SolrTestCaseJ4 {
> }
> }
> };
> - t.run();
> + t.run(); // red flag, shouldn't this be t.start?
> threads.add(t);
> finalCount += index; //int_i
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org