You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/27 06:15:21 UTC

[GitHub] [cordova-contribute] GedasGa opened a new pull request #25: Update GitHub Issue and Pull Request templates

GedasGa opened a new pull request #25: Update GitHub Issue and Pull Request templates
URL: https://github.com/apache/cordova-contribute/pull/25
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details, please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Update GitHub Issues and Pull Request templates.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   - Improve wording
   - Fix grammar mistakes
   - Update Pull Request checklist
   - Remove unnecessary details
   
   I feel like we don't necessarily need to include checklist item:`Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)`. I would like to remove it because I have barely seen anyone do that.
   
   Also, I would like to remove `Platforms affected` section for the platform's repositories, maybe electron could have it since it has 3 different platforms.
   
   I create this PR as an open-ended discussion for further improvements and suggestions.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org