[GitHub] [superset] kgabryje commented on a diff in pull request #25447: fix: Duplicate items when pasting into Select

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje commented on code in PR #25447:
URL: https://github.com/apache/superset/pull/25447#discussion_r1340217872


##########
superset-frontend/src/components/Select/AsyncSelect.tsx:
##########
@@ -523,19 +525,33 @@ const AsyncSelect = forwardRef(
       [ref],
     );
 
+    const pastedTextValue = useMemo(

Review Comment:
   1. The name `pastedTextValue` suggests that it's a value, while really it's a function. Should it be called `getPastedTextValue`?
   2. `useMemo(() => () => {...}` is the same as `useCallback(() => {...}` - the latter is easier to read when memorising a function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org