[DISCUSS] Force use of Maven 3.2.5

[Stephen Mallette <sp...@gmail.com>]

This pull request:

https://github.com/apache/tinkerpop/pull/494

introduces a maven plugin that will validate that our public APIs go
unchanged between releases (without justification). Unfortunately, it
forces us to require a minimum of Maven 3.2.5 to build TinkerPop. If you
don't have that version you get this message on mvn clean install:

[ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.7.0:check
(default) on project tinkerpop: The plugin
org.revapi:revapi-maven-plugin:0.7.0 requires Maven version 3.2.5 -> [Help
1]

So - you get a pretty clear message at least. Anyway, I think that having
the API checker will turn out to be quite useful going forward, perhaps
being on the same level of usefulness as the enforcer plugin for
dependencies. We'll assume lazy consensus to require Maven 3.2.5 unless
there are objections in the next 72 hours (Monday, December 5, 2016, 7AM
EST).

Re: [DISCUSS] Force use of Maven 3.2.5

[Jason Plurad <pl...@gmail.com>]

The PR bumps up to Maven 3.3.9.

On Fri, Dec 2, 2016 at 7:14 AM, Stephen Mallette <sp...@gmail.com>
wrote:

> Only reason that I have is to keep the barrier to new developers as low as
> possible.Travis hasn't even upgraded to 3.2.5 - that PR includes trickery
> to upgrade its maven version there so that we can get a build. imo,
>
> On Fri, Dec 2, 2016 at 7:05 AM, Robert Dale <ro...@gmail.com> wrote:
>
> > Is there any reason to stop at a version that hasn't been updated in 2
> > years?  Why not just go to 3.3.x which has been out for 1 year and is the
> > current stable release train (with 3.3.9 being latest)?
> >
> > Robert Dale
> >
> > On Fri, Dec 2, 2016 at 7:00 AM, Stephen Mallette <sp...@gmail.com>
> > wrote:
> >
> > > This pull request:
> > >
> > > https://github.com/apache/tinkerpop/pull/494
> > >
> > > introduces a maven plugin that will validate that our public APIs go
> > > unchanged between releases (without justification). Unfortunately, it
> > > forces us to require a minimum of Maven 3.2.5 to build TinkerPop. If
> you
> > > don't have that version you get this message on mvn clean install:
> > >
> > > [ERROR] Failed to execute goal org.revapi:revapi-maven-
> > plugin:0.7.0:check
> > > (default) on project tinkerpop: The plugin
> > > org.revapi:revapi-maven-plugin:0.7.0 requires Maven version 3.2.5 ->
> > [Help
> > > 1]
> > >
> > > So - you get a pretty clear message at least. Anyway, I think that
> having
> > > the API checker will turn out to be quite useful going forward, perhaps
> > > being on the same level of usefulness as the enforcer plugin for
> > > dependencies. We'll assume lazy consensus to require Maven 3.2.5 unless
> > > there are objections in the next 72 hours (Monday, December 5, 2016,
> 7AM
> > > EST).
> > >
> >
>

Re: [DISCUSS] Force use of Maven 3.2.5

[Stephen Mallette <sp...@gmail.com>]

Only reason that I have is to keep the barrier to new developers as low as
possible.Travis hasn't even upgraded to 3.2.5 - that PR includes trickery
to upgrade its maven version there so that we can get a build. imo,

On Fri, Dec 2, 2016 at 7:05 AM, Robert Dale <ro...@gmail.com> wrote:

> Is there any reason to stop at a version that hasn't been updated in 2
> years?  Why not just go to 3.3.x which has been out for 1 year and is the
> current stable release train (with 3.3.9 being latest)?
>
> Robert Dale
>
> On Fri, Dec 2, 2016 at 7:00 AM, Stephen Mallette <sp...@gmail.com>
> wrote:
>
> > This pull request:
> >
> > https://github.com/apache/tinkerpop/pull/494
> >
> > introduces a maven plugin that will validate that our public APIs go
> > unchanged between releases (without justification). Unfortunately, it
> > forces us to require a minimum of Maven 3.2.5 to build TinkerPop. If you
> > don't have that version you get this message on mvn clean install:
> >
> > [ERROR] Failed to execute goal org.revapi:revapi-maven-
> plugin:0.7.0:check
> > (default) on project tinkerpop: The plugin
> > org.revapi:revapi-maven-plugin:0.7.0 requires Maven version 3.2.5 ->
> [Help
> > 1]
> >
> > So - you get a pretty clear message at least. Anyway, I think that having
> > the API checker will turn out to be quite useful going forward, perhaps
> > being on the same level of usefulness as the enforcer plugin for
> > dependencies. We'll assume lazy consensus to require Maven 3.2.5 unless
> > there are objections in the next 72 hours (Monday, December 5, 2016, 7AM
> > EST).
> >
>

Re: [DISCUSS] Force use of Maven 3.2.5

[Robert Dale <ro...@gmail.com>]

Is there any reason to stop at a version that hasn't been updated in 2
years?  Why not just go to 3.3.x which has been out for 1 year and is the
current stable release train (with 3.3.9 being latest)?

Robert Dale

On Fri, Dec 2, 2016 at 7:00 AM, Stephen Mallette <sp...@gmail.com>
wrote:

> This pull request:
>
> https://github.com/apache/tinkerpop/pull/494
>
> introduces a maven plugin that will validate that our public APIs go
> unchanged between releases (without justification). Unfortunately, it
> forces us to require a minimum of Maven 3.2.5 to build TinkerPop. If you
> don't have that version you get this message on mvn clean install:
>
> [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.7.0:check
> (default) on project tinkerpop: The plugin
> org.revapi:revapi-maven-plugin:0.7.0 requires Maven version 3.2.5 -> [Help
> 1]
>
> So - you get a pretty clear message at least. Anyway, I think that having
> the API checker will turn out to be quite useful going forward, perhaps
> being on the same level of usefulness as the enforcer plugin for
> dependencies. We'll assume lazy consensus to require Maven 3.2.5 unless
> there are objections in the next 72 hours (Monday, December 5, 2016, 7AM
> EST).
>