You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/05/04 13:13:39 UTC
[PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
slawekjaranowski opened a new pull request, #76:
URL: https://github.com/apache/maven-invoker/pull/76
https://issues.apache.org/jira/browse/MSHARED-1390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590269182
##########
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##########
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+ /**
+ * Add a raw arguments list to Maven cli command at the end of other arguments.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268823
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg -> !StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
I'd say, shit in, shit out, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #76:
URL: https://github.com/apache/maven-invoker/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#issuecomment-2094686028
@michael-o - done - only minimal changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg -> !StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
Should we really check for empty arg lines?
```
<args>
<arg> </arg>
</args>
```
??
I mean that is a deliberate input, no?
##########
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##########
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+ /**
+ * Add a raw arguments list to Maven cli command at the end of other arguments.
Review Comment:
Between "raw" and "arguments" should be one space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268473
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg -> !StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
in `addArg` we do the same ...
I'm not sure how it works with empty arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590274270
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg -> !StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
ok, such those are new methods we can simplify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org