[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

["weizhouapache (via GitHub)" <gi...@apache.org>]

weizhouapache commented on code in PR #7160:
URL: https://github.com/apache/cloudstack/pull/7160#discussion_r1189469260


##########
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java:
##########
@@ -2822,7 +2822,10 @@ private ManagedObjectReference getVmfsDatastore(VmwareContext context, VmwareHyp
             throw new Exception("A relevant SCSI disk could not be located to use to create a datastore.");
         }
 
-        morDs = firstHostDatastoreSystemMO.createVmfsDatastore(datastoreName, hostScsiDisk);
+        morDs = firstHostDatastoreSystemMO.findDatastoreByName(datastoreName);

Review Comment:
   @shwstppr 
   this uses same code as line 2810
   we could change both lines if you agree this is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org