You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/10 17:10:03 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5710: boards/arm/samv7: rework linker script usage logic to allow custom linker scripts

xiaoxiang781216 commented on a change in pull request #5710:
URL: https://github.com/apache/incubator-nuttx/pull/5710#discussion_r823950687



##########
File path: boards/arm/samv7/common/scripts/kernel-space.ld
##########
@@ -18,7 +18,7 @@
  *
  ****************************************************************************/
 
-/* NOTE:  This depends on the memory.ld script having been included prior to
+/* NOTE:  This depends on the memory.ld.template script having been included prior to

Review comment:
       move "prior to" to next line

##########
File path: boards/arm/samv7/common/scripts/user-space.ld
##########
@@ -18,7 +18,7 @@
  *
  ****************************************************************************/
 
-/* NOTE:  This depends on the memory.ld script having been included prior to
+/* NOTE:  This depends on the memory.ld.template script having been included prior to

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org