[GitHub] [spark] cloud-fan commented on a change in pull request #30106: [WIP]Introducing a separation of concerns between data sources that are gi…

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30106:
URL: https://github.com/apache/spark/pull/30106#discussion_r509365032



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/SchemaOnWriteDataSource.scala
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.connector.catalog.TableProvider
+import org.apache.spark.sql.sources.DataSourceRegister
+
+/**
+ * A data source that is given the DataFrame's schema upon write operations.
+ */
+trait SchemaOnWriteDataSource extends TableProvider with DataSourceRegister {

Review comment:
       One option is to add this trait, and another option is to officially make `FileDataSourceV2` a public developer API. Does this "schema-on-write" behavior make sense for non-file data sources?
   
   cc @gengliangwang 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org