You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/10 22:34:21 UTC

[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #3101: [GOBBLIN-1261] Migrate .pdsc schemas to .pdl

jack-moseley opened a new pull request #3101:
URL: https://github.com/apache/incubator-gobblin/pull/3101


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1261
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   This PR migrates PDSC pegasus schema files to PDL format. See https://linkedin.github.io/rest.li/pdl_migration for more information.
   
   Steps that were taken:
   - Bump to latest pegasus version (at least `28.1.3` is required). To do this, had to add linkedin maven repo `https://linkedin.bintray.com/maven` in a few places, since maven central does not have recent versions of pegasus.
   - Ran `convertToPdl` gradle task which automatically converted all the schemas.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Tested by successfully building after migration
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] arjun4084346 commented on pull request #3101: [GOBBLIN-1261] Migrate .pdsc schemas to .pdl

Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on pull request #3101:
URL: https://github.com/apache/incubator-gobblin/pull/3101#issuecomment-692986354


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] asfgit closed pull request #3101: [GOBBLIN-1261] Migrate .pdsc schemas to .pdl

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3101:
URL: https://github.com/apache/incubator-gobblin/pull/3101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-gobblin] jack-moseley commented on pull request #3101: [GOBBLIN-1261] Migrate .pdsc schemas to .pdl

Posted by GitBox <gi...@apache.org>.
jack-moseley commented on pull request #3101:
URL: https://github.com/apache/incubator-gobblin/pull/3101#issuecomment-692211764


   @arjun4084346 please review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org