You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/06/24 02:05:49 UTC
[I] Consolidate WorkflowExecutionService error reporting into a single site (error-free construction + init phase) [texera]
aglinxinyuan opened a new issue, #5921:
URL: https://github.com/apache/texera/issues/5921
### Context
#5781 surfaces init-time fatal errors to the frontend. Because `WorkflowExecutionService` construction itself can throw (it makes external calls), that fix uses **two** reporting phases in `WorkflowService.initExecutionService`:
1. **Pre-publish** — a failure inside `new WorkflowExecutionService(...)`, before `executionService.onNext(...)` publishes it: reported directly via `errorSubject`.
2. **Post-publish** — a failure after the execution is published: the metadata-store diff handler emits a `WorkflowErrorEvent`.
This works (and was reviewed as a fair design), but error reporting lives in two places.
### Proposed refactor (per @Yicong-Huang)
Consolidate to a **single reporting site bundled with `WorkflowExecutionService`**:
1. Make `WorkflowExecutionService` **construction error-free** — no external calls (DB inserts, controller/client creation, etc.) — and register the error-reporting (`fatalErrors` → `WorkflowErrorEvent`) diff handler as the **first** construction action.
2. Move the throwing work into a separate **`init()`** phase run after construction. Any error during `init()` is then reported by the logic already wired during construction.
### Benefit
Single error-reporting site, owned by `WorkflowExecutionService` — removes the two-phase split (and the `errorSubject` fallback) in `WorkflowService.initExecutionService`.
### Challenge
The current constructor performs external calls; making it genuinely side-effect-free requires moving those into `init()` without breaking call sites that depend on construction side effects.
Follow-up to #5781.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Consolidate WorkflowExecutionService error reporting into a single site (error-free construction + init phase) [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5921:
URL: https://github.com/apache/texera/issues/5921#issuecomment-4785258510
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @aglinxinyuan!
It looks like the issue description doesn't quite follow our template yet:
- The **Task Summary** section is missing; please keep the template's headings.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Consolidate WorkflowExecutionService error reporting into a single site (error-free construction + init phase) [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed issue #5921: Consolidate WorkflowExecutionService error reporting into a single site (error-free construction + init phase)
URL: https://github.com/apache/texera/issues/5921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Consolidate WorkflowExecutionService error reporting into a single site (error-free construction + init phase) [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5921:
URL: https://github.com/apache/texera/issues/5921#issuecomment-4785258471
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @aglinxinyuan!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org