You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by pythonmax <gi...@git.apache.org> on 2016/12/05 15:57:08 UTC

[GitHub] zeppelin pull request #1728: [ZEPPELIN-1754] PING request stacking on websoc...

GitHub user pythonmax opened a pull request:

    https://github.com/apache/zeppelin/pull/1728

    [ZEPPELIN-1754] PING request stacking on websocket reconnect

    ### What is this PR for?
    Fixes a bug when PING requests are stacking when server restarted.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    No
    
    ### What is the Jira issue?
    [ZEPPELIN-1754]
    
    ### How should this be tested?
    1) build Zeppelin leaving console.log enabled
    2) start ZeppelinServer, open any notebook in browser
    3) open console with timestamps and check that PING request repeats exactly once in every 10 second
    4) restart ZeppelinServer but do not close or refresh the notebook page
    5) wait for websocket connection reopened
    6) check PING request frequency in console
    PING requests should repeat not often than once per 10 seconds.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    No
    
    * Is there breaking changes for older versions?
    No
    
    * Does this needs documentation?
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elyland/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1728
    
----
commit 13b65a277bbb2eca2ff6e7b6a5aceedcd593398a
Author: Mleekko <ml...@gmail.com>
Date:   2016-11-16T17:13:17Z

    [ZEPPELIN-1013] Don't run paragraph on selectbox change

commit 6103fa906627a65c71ea07e02b275ea19d1c7907
Author: Python_Max <py...@gmail.com>
Date:   2016-12-05T14:53:05Z

    Merge remote-tracking branch 'upstream/master'

commit d38402496c8f10849c781be525ba49acf4013539
Author: Python_Max <py...@gmail.com>
Date:   2016-12-05T15:45:40Z

    [ZEPPELIN-1754] PING request stacking on websocket reconnect

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...

Posted by marchpig <gi...@git.apache.org>.

Github user marchpig commented on the issue:

    https://github.com/apache/zeppelin/pull/1728
  
    I've tested it and works as expected.
    LGTM! But please trigger CI again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1728: [ZEPPELIN-1754] PING request stacking on websoc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1728


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1728
  
    LGTM and merge to master if there're no more comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---