You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/04/15 03:09:05 UTC
[jira] Issue Comment Edited: (HADOOP-3256) JobHistory file on HDFS
should not use the 'job name'
[ https://issues.apache.org/jira/browse/HADOOP-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588861#action_12588861 ]
szetszwo edited comment on HADOOP-3256 at 4/14/08 6:08 PM:
-------------------------------------------------------------------------
Another easy fix is using jobid + hash(other stuffs).
was (Author: szetszwo):
Another easy is to use jobid + hash(other stuffs).
> JobHistory file on HDFS should not use the 'job name'
> -----------------------------------------------------
>
> Key: HADOOP-3256
> URL: https://issues.apache.org/jira/browse/HADOOP-3256
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
>
> HADOOP-2178 introduced the feature of saving jobhistory logs on HDFS.
> Unfortunately the following code:
> {noformat}
> // setup the history log file for this job
> String logFileName = jobUniqueString +
> "_" + user+ "_" + jobName;
> if (logFileName.length() > MAX_FILENAME_SIZE) {
> logFileName = logFileName.substring(0, MAX_FILENAME_SIZE-1);
> }
> {noformat}
> is vulnerable to user-provided job names.
> Specifically I ran into 'URISyntaxException' with jobs whose names include a ":".
> The easy fix is to ensure that we do not use the human-friendly job names and only the jobid.
> The long term fix is to ensure that Path handles filenames with _any_ characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.